Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 10690171: libwebp: fix some int <-> size_t mix for buffer sizes (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)
Modified:
8 years, 5 months ago
Reviewers:
jzern, skal, Chris Evans, aarya
CC:
chromium-reviews, inferno
Visibility:
Public.

Description

libwebp: fix some int <-> size_t mix for buffer sizes This is to prevent overflow to negative. (althought we're testing total_size = (size_t)total_size) Patch by skal@google.com. BUG=136894 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146440

Patch Set 1 #

Total comments: 1

Patch Set 2 : new patch #

Patch Set 3 : even newer patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M third_party/libwebp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/dec/buffer.c View 3 chunks +12 lines, -11 lines 0 comments Download
M third_party/libwebp/webp/decode.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/libwebp/webp/types.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scherkus (not reviewing)
Will wait for skal@ to give the final l-g-t-m after he's done testing
8 years, 5 months ago (2012-07-12 17:44:25 UTC) #1
aarya
8 years, 5 months ago (2012-07-12 17:44:54 UTC) #2
jzern
https://chromiumcodereview.appspot.com/10690171/diff/1/third_party/libwebp/webp/decode.h File third_party/libwebp/webp/decode.h (right): https://chromiumcodereview.appspot.com/10690171/diff/1/third_party/libwebp/webp/decode.h#newcode125 third_party/libwebp/webp/decode.h:125: int size; // total size of the *rgba buffer. ...
8 years, 5 months ago (2012-07-12 20:12:29 UTC) #3
Peter Kasting
Random drive-by: In Chrome I'd call out the use of C-style casts and ask for ...
8 years, 5 months ago (2012-07-12 20:33:22 UTC) #4
scherkus (not reviewing)
PTAL jzern/skal/etc that this is the fix we want to land pkasting: I guess c-casts ...
8 years, 5 months ago (2012-07-12 21:16:51 UTC) #5
scherkus (not reviewing)
actually libwebp _is_ C code -- so there you have it!
8 years, 5 months ago (2012-07-12 21:17:28 UTC) #6
skal
LGTM thanks Andrew for doing the lifting! Peter: it's even worse than that: libwebp is ...
8 years, 5 months ago (2012-07-12 21:21:38 UTC) #7
jzern
8 years, 5 months ago (2012-07-12 21:30:47 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698