Issue 10690153: Merge 145987 - Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690153: Merge 145987 - Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts. (Closed)

Created:
8 years, 5 months ago by gab

Modified:
8 years, 5 months ago

Reviewers:
gab

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

More Reviews

Description

Merge 145987 - Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts. Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in. This results in losing Metro properties when the shortcut is modified on Windows 8. BUG=136567 TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix). Review URL: https://chromiumcodereview.appspot.com/10692138 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146241

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/file_util_win.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages