Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 10692138: Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts. (Closed)

Created:
8 years, 5 months ago by gab
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, chrome-win8-eng_google.com
Visibility:
Public.

Description

Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts. Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in. This results in losing Metro properties when the shortcut is modified on Windows 8. BUG=136567 TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/file_util_win.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
8 years, 5 months ago (2012-07-10 19:20:58 UTC) #1
grt (UTC plus 2)
lgtm
8 years, 5 months ago (2012-07-10 20:06:50 UTC) #2
brettw
lgtm
8 years, 5 months ago (2012-07-10 20:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10692138/1
8 years, 5 months ago (2012-07-10 20:25:10 UTC) #4
commit-bot: I haz the power
Try job failure for 10692138-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 21:58:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10692138/1
8 years, 5 months ago (2012-07-10 22:05:59 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 23:29:16 UTC) #7
Change committed as 145987

Powered by Google App Engine
This is Rietveld 408576698