Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: build/common.gypi

Issue 10690103: Do not link non-executables with -pie for tsan=1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 145638)
+++ build/common.gypi (working copy)
@@ -2319,12 +2319,18 @@
],
'ldflags': [
'-fthread-sanitizer',
- '-pie',
],
'defines': [
'THREAD_SANITIZER',
'DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=1',
],
+ 'target_conditions': [
+ ['_type=="executable"', {
+ 'ldflags': [
+ '-pie',
+ ],
Nico 2012/07/20 18:06:11 nit: we use 2 spaces indent in gyp files, not 4. m
Alexander Potapenko 2012/07/25 08:36:44 Done.
+ }],
+ ],
}],
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698