Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 10690071: [Sync] Move model_type* from syncable/ to base/ (Closed)

Created:
8 years, 5 months ago by akalin
Modified:
8 years, 5 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Move model_type* from syncable/ to base/ Also move enum_set* to base/. This is the first step in moving ModelType et al. to the syncer namespace (from syncer::syncable). Move PurgeStalePayload() back to sync_session.cc. Move ModelTypePayloadMapFromRoutingInfo() to model_safe_worker.* and rename it to ModelSafeRoutingInfoToPayloadMap(). BUG=128060 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -1265 lines) Patch
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/backend_data_type_configurer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/change_processor_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/chrome_sync_notification_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_error_handler_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/user_selectable_sync_type.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/api/sync_data.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_error.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/syncable_service.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/all_status.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/all_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/cleanup_disabled_types_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/cleanup_disabled_types_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/download_updates_command.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/download_updates_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/model_changing_syncer_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/process_updates_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/resolve_conflicts_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/store_timestamps_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M sync/engine/syncer.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/syncer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncproto.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/throttled_data_type_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/throttled_data_type_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/throttled_data_type_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/change_reorder_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A sync/internal_api/public/base/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + sync/internal_api/public/base/enum_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/base/enum_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/base/model_type.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/base/model_type_payload_map.h View 4 chunks +4 lines, -16 lines 0 comments Download
A + sync/internal_api/public/base/model_type_payload_map.cc View 3 chunks +1 line, -29 lines 0 comments Download
A + sync/internal_api/public/base/model_type_payload_map_unittest.cc View 2 chunks +28 lines, -1 line 0 comments Download
A + sync/internal_api/public/base/model_type_test_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/base/model_type_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base_node.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 2 chunks +8 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M sync/internal_api/public/engine/sync_status.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/read_node.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/public/syncable/model_type.h View 1 chunk +0 lines, -227 lines 0 comments Download
D sync/internal_api/public/syncable/model_type_payload_map.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sync/internal_api/public/syncable/model_type_payload_map.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D sync/internal_api/public/syncable/model_type_payload_map_unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D sync/internal_api/public/syncable/model_type_test_util.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sync/internal_api/public/syncable/model_type_test_util.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M sync/internal_api/public/test/test_entry_factory.h View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/public/util/enum_set.h View 1 chunk +0 lines, -286 lines 0 comments Download
D sync/internal_api/public/util/enum_set_unittest.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M sync/internal_api/public/util/experiments.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/write_node.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/syncapi_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M sync/notifier/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/invalidation_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/p2p_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/p2p_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/p2p_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_notifier_factory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/sync_notifier_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/sync_protocol_error.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/ordered_commit_set.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/status_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/sync_session.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/sync_session.cc View 2 chunks +19 lines, -1 line 0 comments Download
M sync/sessions/sync_session_unittest.cc View 2 chunks +1 line, -40 lines 0 comments Download
M sync/sync.gyp View 4 chunks +8 lines, -8 lines 0 comments Download
M sync/syncable/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_backing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_change_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/entry_kernel.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/model_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/model_type_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/nigori_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/transaction_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/engine/syncer_command_test.h View 1 chunk +1 line, -2 lines 0 comments Download
M sync/tools/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/util/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/cryptographer.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/cryptographer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/data_type_histogram.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
Most of the touched files have only their headers changed.
8 years, 5 months ago (2012-07-03 00:13:33 UTC) #1
rlarocque
LGTM.
8 years, 5 months ago (2012-07-03 00:26:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10690071/1
8 years, 5 months ago (2012-07-03 00:30:10 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 01:30:59 UTC) #4
Change committed as 145236

Powered by Google App Engine
This is Rietveld 408576698