Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10689185: Revert 146262 - Revert "Revert 142517 - [Sync] Refactor sync configuration logic." (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 5 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Revert 146262 - Revert "Revert 142517 - [Sync] Refactor sync configuration logic." Relanding with improved tests and support for cleaning up partial nigori. The original patch was reverted due to users who needed to download a new nigori node, but who had since been migrated. We do not handle migration before the backend is initialized, so we now go ahead and detect+delete partial nigori nodes before redownloading them. By blowing away the old progress marker, we're no longer at risk of receiving the migration done response. In order to test this the SyncBackendHost unit tests have been substantially upgraded. original review at: https://chromiumcodereview.appspot.com/10483015 BUG=129665, 133061, 133219 TEST=unit/integration tests Review URL: https://chromiumcodereview.appspot.com/10701085 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -818 lines) Patch
M chrome/browser/sync/glue/backend_data_type_configurer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 4 chunks +46 lines, -27 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 12 chunks +224 lines, -155 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 2 chunks +28 lines, -12 lines 0 comments Download
M sync/engine/sync_scheduler.h View 5 chunks +14 lines, -39 lines 0 comments Download
M sync/engine/sync_scheduler.cc View 13 chunks +93 lines, -157 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 15 chunks +73 lines, -118 lines 0 comments Download
M sync/engine/sync_scheduler_whitebox_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 5 chunks +18 lines, -31 lines 0 comments Download
M sync/internal_api/sync_manager.cc View 12 chunks +52 lines, -106 lines 0 comments Download
M sync/internal_api/syncapi_unittest.cc View 5 chunks +1 line, -125 lines 0 comments Download
M sync/sync.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/directory.h View 1 chunk +1 line, -2 lines 0 comments Download
M sync/syncable/directory.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M sync/syncable/syncable_mock.h View 1 chunk +1 line, -1 line 0 comments Download
D sync/test/callback_counter.h View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
8 years, 5 months ago (2012-07-13 01:35:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698