Refactored code for timezone settings.

chrome/browser/chromeos/system/timezone_settings.h

Index: chrome/browser/chromeos/system/timezone_settings.h
diff --git a/chrome/browser/chromeos/system/timezone_settings.h b/chrome/browser/chromeos/system/timezone_settings.h
index 9cbaecd1338f54c1b6726edbcbaaa249f9e03f8f..48fa08333f1cbdf52b047058ba802c5a69542aee 100644
--- a/chrome/browser/chromeos/system/timezone_settings.h
+++ b/chrome/browser/chromeos/system/timezone_settings.h
@@ -5,8 +5,9 @@
 #ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_TIMEZONE_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_SYSTEM_TIMEZONE_SETTINGS_H_
 
-#include <string>
+#include <vector>
 
+#include "base/string16.h"
 #include "chrome/browser/cancelable_request.h"
 #include "unicode/timezone.h"
 
@@ -26,13 +27,20 @@ class TimezoneSettings : public CancelableRequestProvider {
 
   // Returns the current timezone as an icu::Timezone object.
   virtual const icu::TimeZone& GetTimezone() = 0;
+  virtual const string16 GetCurrentTimezoneID() = 0;

[Joao da Silva, 2012/07/12 18:34:09]

No need for const when returning a value.

[pneubeck2, 2012/07/13 10:31:39]

Done.

 
-  // Sets the current timezone. |timezone| must be non-null.
+  // Sets the current timezone and notifies all Observers.
   virtual void SetTimezone(const icu::TimeZone& timezone) = 0;
+  virtual void SetTimezoneFromID(const string16& timezone_id) = 0;
 
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
+  virtual const std::vector<icu::TimeZone*> &GetTimezoneList() const = 0;

[Joao da Silva, 2012/07/12 18:34:09]

Nit: move the & next to the type

[pneubeck2, 2012/07/13 10:31:39]

Done.

+
+  // Gets timezone ID which is also used as timezone pref value.
+  static string16 GetTimezoneID(const icu::TimeZone& timezone);
+
  protected:
   virtual ~TimezoneSettings() {}
 };