Refactored code for timezone settings.

chrome/browser/chromeos/system/timezone_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_TIMEZONE_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_SYSTEM_TIMEZONE_SETTINGS_H_
 
-#include <string>
+#include <vector>
 
+#include "base/string16.h"
 #include "chrome/browser/cancelable_request.h"
 #include "unicode/timezone.h"
 
 namespace chromeos {
 namespace system {
 
 // This interface provides access to Chrome OS timezone settings.
 class TimezoneSettings : public CancelableRequestProvider {
  public:
   class Observer {

[Joao da Silva, 2012/07/12 18:34:09]

Please add a virtual destructor to this, with an empty implementation on the .cc
file.

[pneubeck2, 2012/07/13 10:31:39]

Done.

    public:
     // Called when the timezone has changed. |timezone| is non-null.
     virtual void TimezoneChanged(const icu::TimeZone& timezone) = 0;
   };
 
   static TimezoneSettings* GetInstance();
 
   // Returns the current timezone as an icu::Timezone object.
   virtual const icu::TimeZone& GetTimezone() = 0;
+  virtual const string16 GetCurrentTimezoneID() = 0;

[Joao da Silva, 2012/07/12 18:34:09]

No need for const when returning a value.

[pneubeck2, 2012/07/13 10:31:39]

Done.

 
-  // Sets the current timezone. |timezone| must be non-null.
+  // Sets the current timezone and notifies all Observers.
   virtual void SetTimezone(const icu::TimeZone& timezone) = 0;
+  virtual void SetTimezoneFromID(const string16& timezone_id) = 0;
 
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
+  virtual const std::vector<icu::TimeZone*> &GetTimezoneList() const = 0;

[Joao da Silva, 2012/07/12 18:34:09]

Nit: move the & next to the type

[pneubeck2, 2012/07/13 10:31:39]

Done.

+
+  // Gets timezone ID which is also used as timezone pref value.
+  static string16 GetTimezoneID(const icu::TimeZone& timezone);
+
  protected:
   virtual ~TimezoneSettings() {}
 };
 
 }  // namespace system
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_TIMEZONE_SETTINGS_H_