Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7885)

Unified Diff: chrome/browser/ui/global_error/global_error.cc

Issue 10689107: Disable use of ShowBubbleView() on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/global_error/global_error.cc
diff --git a/chrome/browser/ui/global_error/global_error.cc b/chrome/browser/ui/global_error/global_error.cc
index 9bfe3a9cd2af6abb1c7437817d2fc730f48d7fc9..1f1b06faa24842b25589db1e9d70cfa5c2866805 100644
--- a/chrome/browser/ui/global_error/global_error.cc
+++ b/chrome/browser/ui/global_error/global_error.cc
@@ -31,8 +31,12 @@ bool GlobalError::HasShownBubbleView() {
void GlobalError::ShowBubbleView(Browser* browser) {
has_shown_bubble_view_ = true;
+#if defined(OS_ANDROID)
Peter Kasting 2012/07/09 17:41:43 Is it correct to leave setting |has_shown_bubble_v
Philippe 2012/07/09 18:10:30 I'm not familiar with this code either :/ My goal
Yaron 2012/07/09 23:23:22 So the upshot is that right now we're silently swa
Philippe 2012/07/10 11:21:55 Done.
+ NOTIMPLEMENTED() << "Chrome for Android doesn't support global errors";
+#else
bubble_view_ =
GlobalErrorBubbleViewBase::ShowBubbleView(browser, AsWeakPtr());
+#endif
}
GlobalErrorBubbleViewBase* GlobalError::GetBubbleView() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698