Disable use of ShowBubbleView() on Android.

chrome/browser/ui/global_error/global_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/global_error/global_error.h"
 
 #include "base/logging.h"
 #include "chrome/browser/ui/global_error/global_error_bubble_view_base.h"
 #include "grit/theme_resources.h"
 #include "grit/theme_resources_standard.h"
@@ skipping 13 matching lines @@
 int GlobalError::MenuItemIconResourceID() {
   return IDR_UPDATE_MENU4;
 }
 
 bool GlobalError::HasShownBubbleView() {
   return has_shown_bubble_view_;
 }
 
 void GlobalError::ShowBubbleView(Browser* browser) {
   has_shown_bubble_view_ = true;
+#if defined(OS_ANDROID)

[Peter Kasting, 2012/07/09 17:41:43]

Is it correct to leave setting |has_shown_bubble_view_| un-guarded?  I'm not
familiar with this code.

[Philippe, 2012/07/09 18:10:30]

I'm not familiar with this code either :/ My goal was really to make unit_tests
link successfully. These are the changes we have internally. It seems that we
don't use GlobalError on Android although we compile it.

[Yaron, 2012/07/09 23:23:22]

So the upshot is that right now we're silently swallowing sync errors unless you
visit about:sync (all other sources of bubble errors can't occur on Android). I
think it's fine to leave this as-is. However, please file a crbug (and reference
here) to track implementing this feature.

[Philippe, 2012/07/10 11:21:55]

Done.

+  NOTIMPLEMENTED() << "Chrome for Android doesn't support global errors";
+#else
   bubble_view_ =
       GlobalErrorBubbleViewBase::ShowBubbleView(browser, AsWeakPtr());
+#endif
 }
 
 GlobalErrorBubbleViewBase* GlobalError::GetBubbleView() {
   return bubble_view_;
 }
 
 int GlobalError::GetBubbleViewIconResourceID() {
   return IDR_INPUT_ALERT;
 }
 
 void GlobalError::BubbleViewDidClose(Browser* browser) {
   DCHECK(browser);
   bubble_view_ = NULL;
   OnBubbleViewDidClose(browser);
 }