Disable use of ShowBubbleView() on Android.

Disable use of ShowBubbleView() on Android.

This is part of Chrome for Android upstreaming (and also needed to link
unit_tests).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145864

[Peter Kasting, 2012-07-09 17:41:43]

LGTM

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
File chrome/browser/ui/global_error/global_error.cc (right):

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
chrome/browser/ui/global_error/global_error.cc:34: #if defined(OS_ANDROID)
Is it correct to leave setting |has_shown_bubble_view_| un-guarded?  I'm not
familiar with this code.

[Philippe, 2012-07-09 18:10:29]

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
File chrome/browser/ui/global_error/global_error.cc (right):

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
chrome/browser/ui/global_error/global_error.cc:34: #if defined(OS_ANDROID)
On 2012/07/09 17:41:43, Peter Kasting wrote:
> Is it correct to leave setting |has_shown_bubble_view_| un-guarded?  I'm not
> familiar with this code.

I'm not familiar with this code either :/ My goal was really to make unit_tests
link successfully. These are the changes we have internally. It seems that we
don't use GlobalError on Android although we compile it.

[Yaron, 2012-07-09 23:23:22]

lgtm

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
File chrome/browser/ui/global_error/global_error.cc (right):

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
chrome/browser/ui/global_error/global_error.cc:34: #if defined(OS_ANDROID)
On 2012/07/09 18:10:30, Philippe wrote:
> On 2012/07/09 17:41:43, Peter Kasting wrote:
> > Is it correct to leave setting |has_shown_bubble_view_| un-guarded?  I'm not
> > familiar with this code.
> 
> I'm not familiar with this code either :/ My goal was really to make
unit_tests
> link successfully. These are the changes we have internally. It seems that we
> don't use GlobalError on Android although we compile it.

So the upshot is that right now we're silently swallowing sync errors unless you
visit about:sync (all other sources of bubble errors can't occur on Android). I
think it's fine to leave this as-is. However, please file a crbug (and reference
here) to track implementing this feature.

[Philippe, 2012-07-10 11:21:55]

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
File chrome/browser/ui/global_error/global_error.cc (right):

https://chromiumcodereview.appspot.com/10689107/diff/1/chrome/browser/ui/glob...
chrome/browser/ui/global_error/global_error.cc:34: #if defined(OS_ANDROID)
On 2012/07/09 23:23:22, Yaron wrote:
> On 2012/07/09 18:10:30, Philippe wrote:
> > On 2012/07/09 17:41:43, Peter Kasting wrote:
> > > Is it correct to leave setting |has_shown_bubble_view_| un-guarded?  I'm
not
> > > familiar with this code.
> > 
> > I'm not familiar with this code either :/ My goal was really to make
> unit_tests
> > link successfully. These are the changes we have internally. It seems that
we
> > don't use GlobalError on Android although we compile it.
> 
> So the upshot is that right now we're silently swallowing sync errors unless
you
> visit about:sync (all other sources of bubble errors can't occur on Android).
I
> think it's fine to leave this as-is. However, please file a crbug (and
reference
> here) to track implementing this feature.

Done.

[commit-bot: I haz the power, 2012-07-10 11:22:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10689107/7001

[commit-bot: I haz the power, 2012-07-10 12:58:48]

Change committed as 145864