chrome/browser/ui/panels/base_panel_browser_test.h - Issue 10689082: Fix flaky linux panel tests related to active state checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.h

Issue 10689082: Fix flaky linux panel tests related to active state checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove log msg Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/base_panel_browser_test.h

diff --git a/chrome/browser/ui/panels/base_panel_browser_test.h b/chrome/browser/ui/panels/base_panel_browser_test.h

index e9fbebe1fd8b9e7f6e64a2b46f298d8b36a9fa5c..4ada135809ee96e5760ea5c67fcb94318ecf0a36 100644

--- a/chrome/browser/ui/panels/base_panel_browser_test.h

+++ b/chrome/browser/ui/panels/base_panel_browser_test.h

@@ -41,7 +41,7 @@ class BasePanelBrowserTest : public InProcessBrowserTest {

// Linux bots use icewm which activate windows in ways that break

// certain panel tests. Skip those tests when running on the bots.

// We do not disable the tests to make it easy for developers to run

- // them locally.

+ // them locally. [Icewm always activates a window when shown.]

bool SkipTestIfIceWM();

// Gnome running compiz refuses to activate a window that was initially

« no previous file with comments | « no previous file | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »