Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/ui/panels/base_panel_browser_test.h

Issue 10689082: Fix flaky linux panel tests related to active state checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove log msg Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_ 5 #ifndef CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_
6 #define CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_ 6 #define CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 23 matching lines...) Expand all
34 virtual void SetDesktopBarThickness(DesktopBarAlignment alignment, 34 virtual void SetDesktopBarThickness(DesktopBarAlignment alignment,
35 int thickness) = 0; 35 int thickness) = 0;
36 }; 36 };
37 37
38 BasePanelBrowserTest(); 38 BasePanelBrowserTest();
39 virtual ~BasePanelBrowserTest(); 39 virtual ~BasePanelBrowserTest();
40 40
41 // Linux bots use icewm which activate windows in ways that break 41 // Linux bots use icewm which activate windows in ways that break
42 // certain panel tests. Skip those tests when running on the bots. 42 // certain panel tests. Skip those tests when running on the bots.
43 // We do not disable the tests to make it easy for developers to run 43 // We do not disable the tests to make it easy for developers to run
44 // them locally. 44 // them locally. [Icewm always activates a window when shown.]
45 bool SkipTestIfIceWM(); 45 bool SkipTestIfIceWM();
46 46
47 // Gnome running compiz refuses to activate a window that was initially 47 // Gnome running compiz refuses to activate a window that was initially
48 // created as inactive, causing certain panel tests to fail. These tests 48 // created as inactive, causing certain panel tests to fail. These tests
49 // pass fine on the bots, but fail for developers as Gnome running compiz 49 // pass fine on the bots, but fail for developers as Gnome running compiz
50 // is the typical linux dev machine configuration. We do not disable the 50 // is the typical linux dev machine configuration. We do not disable the
51 // tests to ensure we still have coverage on the bots. 51 // tests to ensure we still have coverage on the bots.
52 bool SkipTestIfCompizWM(); 52 bool SkipTestIfCompizWM();
53 53
54 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE; 54 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 static const FilePath::CharType* kTestDir; 122 static const FilePath::CharType* kTestDir;
123 123
124 private: 124 private:
125 // Passed to and owned by PanelManager. 125 // Passed to and owned by PanelManager.
126 MockDisplaySettingsProvider* mock_display_settings_provider_; 126 MockDisplaySettingsProvider* mock_display_settings_provider_;
127 127
128 bool mock_display_settings_enabled_; 128 bool mock_display_settings_enabled_;
129 }; 129 };
130 130
131 #endif // CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_ 131 #endif // CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698