base/string_split_unittest.cc - Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_split_unittest.cc

Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/string_split_unittest.cc

===================================================================

--- base/string_split_unittest.cc (revision 144240)

+++ base/string_split_unittest.cc (working copy)

@@ -267,7 +267,6 @@

SplitStringDontTrim(" ", '*', &r);

ASSERT_EQ(1U, r.size());

EXPECT_EQ(r[0], " ");

- r.clear();

SplitStringDontTrim("\t \ta\t ", '\t', &r);

ASSERT_EQ(4U, r.size());

@@ -275,13 +274,11 @@

EXPECT_EQ(r[1], " ");

EXPECT_EQ(r[2], "a");

EXPECT_EQ(r[3], " ");

- r.clear();

SplitStringDontTrim("\ta\t\nb\tcc", '\n', &r);

ASSERT_EQ(2U, r.size());

EXPECT_EQ(r[0], "\ta\t");

EXPECT_EQ(r[1], "b\tcc");

- r.clear();

}

TEST(StringSplitTest, SplitStringAlongWhitespace) {

« no previous file with comments | « base/string_split.cc ('k') | net/ftp/ftp_directory_listing_parser_vms.cc » ('j') | no next file with comments »