Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: chrome/test/mini_installer_test/installer_test_util.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome_frame/dll_redirector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/mini_installer_test/installer_test_util.cc
diff --git a/chrome/test/mini_installer_test/installer_test_util.cc b/chrome/test/mini_installer_test/installer_test_util.cc
index ad93c549caa563f63529a35d0069f71cf20294c4..8565dfd3b35f99ec9459b7dfbf44c882c964f5f0 100644
--- a/chrome/test/mini_installer_test/installer_test_util.cc
+++ b/chrome/test/mini_installer_test/installer_test_util.cc
@@ -112,11 +112,11 @@ bool GetInstalledProducts(
if (type != InstallationValidator::NO_PRODUCTS) {
current_dist = BrowserDistribution::GetSpecificDistribution(
ToBrowserDistributionType(type));
- scoped_ptr<Version> version(
- InstallUtil::GetChromeVersion(current_dist, system_level));
- if (version.get()) {
+ Version version;
+ InstallUtil::GetChromeVersion(current_dist, system_level, &version);
+ if (version.IsValid()) {
current_prod.type = type;
- current_prod.version = version->GetString();
+ current_prod.version = version.GetString();
current_prod.system = system_level;
products->push_back(current_prod);
}
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome_frame/dll_redirector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698