Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7973)

Unified Diff: chrome/installer/util/product_unittest.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/product_unittest.cc
diff --git a/chrome/installer/util/product_unittest.cc b/chrome/installer/util/product_unittest.cc
index b96bba41dbc5be37712e4bc83535bf640bf5e855..1c7d6133301114fa04cd207472b647bba2fffee1 100644
--- a/chrome/installer/util/product_unittest.cc
+++ b/chrome/installer/util/product_unittest.cc
@@ -98,10 +98,9 @@ TEST_F(ProductTest, MAYBE_ProductInstallBasic) {
ASSERT_TRUE(version_key.Valid());
const char kCurrentVersion[] = "1.2.3.4";
- scoped_ptr<Version> current_version(
- Version::GetVersionFromString(kCurrentVersion));
+ Version current_version(kCurrentVersion);
version_key.WriteValue(google_update::kRegVersionField,
- UTF8ToWide(current_version->GetString()).c_str());
+ UTF8ToWide(current_version.GetString()).c_str());
// We started out with a non-msi product.
machine_state.Initialize();
@@ -109,7 +108,7 @@ TEST_F(ProductTest, MAYBE_ProductInstallBasic) {
machine_state.GetProductState(system_level, distribution->GetType());
EXPECT_TRUE(chrome_state != NULL);
if (chrome_state != NULL) {
- EXPECT_TRUE(chrome_state->version().Equals(*current_version.get()));
+ EXPECT_TRUE(chrome_state->version().Equals(current_version));
EXPECT_FALSE(chrome_state->is_msi());
}
« no previous file with comments | « chrome/installer/util/installer_state_unittest.cc ('k') | chrome/test/mini_installer_test/installer_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698