Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5419)

Unified Diff: chrome/browser/plugin_installer.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/hang_monitor/hung_plugin_action.cc ('k') | chrome/browser/ui/views/about_chrome_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_installer.cc
diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc
index 6a76213f2c0077c99dd3a2a31ceb768ce5ca14aa..f79566211f87cc90e2960f9006b3814380020d66 100644
--- a/chrome/browser/plugin_installer.cc
+++ b/chrome/browser/plugin_installer.cc
@@ -96,14 +96,14 @@ PluginInstaller::SecurityStatus PluginInstaller::GetSecurityStatus(
if (versions_.empty())
return SECURITY_STATUS_REQUIRES_AUTHORIZATION;
- scoped_ptr<Version> version(
- webkit::npapi::PluginGroup::CreateVersionFromString(plugin.version));
- if (!version.get())
- version.reset(new Version("0"));
+ Version version;
+ webkit::npapi::PluginGroup::CreateVersionFromString(plugin.version, &version);
+ if (!version.IsValid())
+ version = Version("0");
// |lower_bound| returns the latest version that is not newer than |version|.
std::map<Version, SecurityStatus, VersionComparator>::const_iterator it =
- versions_.lower_bound(*version);
+ versions_.lower_bound(version);
// If there is at least one version defined, everything older than the oldest
// defined version is considered out-of-date.
if (it == versions_.end())
« no previous file with comments | « chrome/browser/hang_monitor/hung_plugin_action.cc ('k') | chrome/browser/ui/views/about_chrome_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698