Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: chrome/browser/hang_monitor/hung_plugin_action.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gpu_util.cc ('k') | chrome/browser/plugin_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/hang_monitor/hung_plugin_action.cc
diff --git a/chrome/browser/hang_monitor/hung_plugin_action.cc b/chrome/browser/hang_monitor/hung_plugin_action.cc
index 35ae2a4d5285346cb7344907357b634d9a9c060d..84feb7a60f424fabf5212d45a8327bf6de60f723 100644
--- a/chrome/browser/hang_monitor/hung_plugin_action.cc
+++ b/chrome/browser/hang_monitor/hung_plugin_action.cc
@@ -40,11 +40,11 @@ enum GTalkPluginLogVersion {
// 10 * major + minor - kGTalkPluginLogMinVersion.
GTalkPluginLogVersion GetGTalkPluginVersion(const string16& version) {
int gtalk_plugin_version = GTALK_PLUGIN_VERSION_MIN;
- scoped_ptr<Version> plugin_version(
- webkit::npapi::PluginGroup::CreateVersionFromString(version));
- if (plugin_version.get() && plugin_version->components().size() >= 2) {
- gtalk_plugin_version = 10 * plugin_version->components()[0] +
- plugin_version->components()[1] - kGTalkPluginLogMinVersion;
+ Version plugin_version;
+ webkit::npapi::PluginGroup::CreateVersionFromString(version, &plugin_version);
+ if (plugin_version.IsValid() && plugin_version.components().size() >= 2) {
+ gtalk_plugin_version = 10 * plugin_version.components()[0] +
+ plugin_version.components()[1] - kGTalkPluginLogMinVersion;
}
if (gtalk_plugin_version < GTALK_PLUGIN_VERSION_MIN)
« no previous file with comments | « chrome/browser/gpu_util.cc ('k') | chrome/browser/plugin_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698