Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc
index f72c730609138db3d29233ce7433f02f09427cc5..d3806c577e57312a296de3153df883a9efc8d633 100644
--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc
@@ -857,10 +857,9 @@ class ExtensionUpdaterTest : public testing::Test {
std::string id = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
std::string hash = "";
- scoped_ptr<Version> version(Version::GetVersionFromString("0.0.1"));
- ASSERT_TRUE(version.get());
+ Version version("0.0.1");
updater.downloader_->FetchUpdatedExtension(
- id, test_url, hash, version->GetString());
+ id, test_url, hash, version.GetString());
if (pending) {
const bool kIsFromSync = true;
@@ -868,7 +867,7 @@ class ExtensionUpdaterTest : public testing::Test {
PendingExtensionManager* pending_extension_manager =
service->pending_extension_manager();
pending_extension_manager->AddForTesting(
- PendingExtensionInfo(id, test_url, *version,
+ PendingExtensionInfo(id, test_url, version,
&ShouldAlwaysInstall, kIsFromSync,
kInstallSilently,
Extension::INTERNAL));
« no previous file with comments | « chrome/browser/extensions/external_registry_extension_loader_win.cc ('k') | chrome/browser/extensions/user_script_master.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698