chrome/browser/extensions/external_registry_extension_loader_win.cc - Issue 10683005: Remove two deprecated methods from base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_extension_loader_win.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_extension_provider_impl.cc ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_registry_extension_loader_win.cc

diff --git a/chrome/browser/extensions/external_registry_extension_loader_win.cc b/chrome/browser/extensions/external_registry_extension_loader_win.cc

index 45651a3f8f70ca914ef0678c11cf1ec8993a4dfc..ab90bfc5a9bf3868c4096c0055cff7f2340bcc6d 100644

--- a/chrome/browser/extensions/external_registry_extension_loader_win.cc

+++ b/chrome/browser/extensions/external_registry_extension_loader_win.cc

@@ -129,10 +129,8 @@ void ExternalRegistryExtensionLoader::LoadOnFileThread() {

continue;

}

- scoped_ptr<Version> version;

- version.reset(Version::GetVersionFromString(

- WideToASCII(extension_version)));

- if (!version.get()) {

+ Version version(WideToASCII(extension_version));

+ if (!version.IsValid()) {

LOG(ERROR) << "Invalid version value " << extension_version

<< " for key " << key_path << ".";

continue;