Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: base/version.h

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.h
diff --git a/base/version.h b/base/version.h
index b6029d3c758a14ffb04fa8117830c0faa165611e..fc5792383d4457870e9cab609b98f744cb131941 100644
--- a/base/version.h
+++ b/base/version.h
@@ -36,15 +36,6 @@ class BASE_EXPORT Version {
// than the version of this object.
bool IsOlderThan(const std::string& version_str) const;
- // Returns NULL if the string is not in the proper format.
- // Caller is responsible for freeing the Version object once done.
- // DO NOT USE FOR NEWER CODE.
- static Version* GetVersionFromString(const std::string& version_str);
-
- // Creates a copy of this version object. Caller takes ownership.
- // DO NOT USE FOR NEWER CODE.
- Version* Clone() const;
-
bool Equals(const Version& other) const;
// Returns -1, 0, 1 for <, ==, >.
« no previous file with comments | « no previous file | base/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698