Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: base/version.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/version.h ('k') | base/version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.cc
diff --git a/base/version.cc b/base/version.cc
index 1f9bd204e0c6898ee1ce421a279f8323f81957d2..070c66570f6b1b93033aeb0485f3fd773cdcb6f4 100644
--- a/base/version.cc
+++ b/base/version.cc
@@ -52,22 +52,6 @@ bool Version::IsOlderThan(const std::string& version_str) const {
return (CompareTo(proposed_ver) < 0);
}
-// TODO(cpu): remove this method.
-Version* Version::GetVersionFromString(const std::string& version_str) {
- Version* vers = new Version(version_str);
- if (vers->IsValid()) {
- return vers;
- }
- delete vers;
- return NULL;
-}
-
-// TODO(cpu): remove this method.
-Version* Version::Clone() const {
- DCHECK(IsValid());
- return new Version(*this);
-}
-
bool Version::Equals(const Version& that) const {
DCHECK(IsValid());
DCHECK(that.IsValid());
« no previous file with comments | « base/version.h ('k') | base/version_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698