Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10680004: HACK on m21 branch 1180 to avoid flickering of buffered bar by lying. (Closed)

Created:
8 years, 6 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org, kareng
Visibility:
Public.

Description

HACK on m21 branch 1180 to avoid flickering of buffered bar by lying. Instead of reporting multi-range buffered information, revert to reporting a single [0,max) buffered range, where max is an unholy combination of currentTime()+0.5s (to ensure the bar never disappears), duration() (to ensure the bar doesn't overflow), and the real end of the buffered ranges from the pipeline (to still retain some semblance of usefulness, when the bytes/time ratio is stable enough). BUG=133567

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M webkit/media/webmediaplayer_impl.cc View 1 chunk +12 lines, -5 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Ami GONE FROM CHROMIUM
scherkus: this is the branch-only hack I mentioned in IM. WDYT?
8 years, 6 months ago (2012-06-26 20:16:04 UTC) #1
scherkus (not reviewing)
lgtm https://chromiumcodereview.appspot.com/10680004/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://chromiumcodereview.appspot.com/10680004/diff/1/webkit/media/webmediaplayer_impl.cc#newcode485 webkit/media/webmediaplayer_impl.cc:485: WebKit::WebTimeRanges web_ranges(static_cast<size_t>(1)); 1u doesn't work!? :~(
8 years, 5 months ago (2012-06-27 17:52:18 UTC) #2
Ami GONE FROM CHROMIUM
8 years, 5 months ago (2012-06-27 18:15:19 UTC) #3
https://chromiumcodereview.appspot.com/10680004/diff/1/webkit/media/webmediap...
File webkit/media/webmediaplayer_impl.cc (right):

https://chromiumcodereview.appspot.com/10680004/diff/1/webkit/media/webmediap...
webkit/media/webmediaplayer_impl.cc:485: WebKit::WebTimeRanges
web_ranges(static_cast<size_t>(1));
On 2012/06/27 17:52:18, scherkus wrote:
> 1u doesn't work!? :~(

Nope.  The template foo in WebVector tries to treat "1" as a class type and
confuses the compiler.  Haven't dug into why.

Powered by Google App Engine
This is Rietveld 408576698