Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 10677016: Enable clang checks for bad refcounting patterns on ChromeOS (Closed)

Created:
8 years, 6 months ago by Ryan Sleevi
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Enable clang checks for bad refcounting patterns on ChromeOS BUG=123295 TEST=it compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
Nico: Tryjobs pending to see if anything else squeaked by, but I think it should ...
8 years, 6 months ago (2012-06-27 01:28:47 UTC) #1
Nico
lgtm
8 years, 6 months ago (2012-06-27 01:36:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10677016/1
8 years, 6 months ago (2012-06-27 03:51:05 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-27 05:02:21 UTC) #4
Change committed as 144405

Powered by Google App Engine
This is Rietveld 408576698