Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: build/common.gypi

Issue 10677016: Enable clang checks for bad refcounting patterns on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 53d94974c006a26b320b8f4b5a92ef3e36301669..5bd2879b51fff2cf203dbc7130e6fcd8452152d2 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1092,27 +1092,8 @@
'grit_defines': ['-D', 'enable_printing'],
}],
['clang_use_chrome_plugins==1 and OS!="win"', {
- 'variables': {
- 'clang_chrome_plugins_flags': [
- '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
- ],
- },
- 'conditions': [
- ['chromeos==1', {
- # TODO(rsleevi): http://crbug.com/123295 - Disabled on ChromeOS
- # for now.
- 'clang_chrome_plugins_flags': [
- '<@(clang_chrome_plugins_flags)',
- '-Xclang',
- '-plugin-arg-find-bad-constructs',
- '-Xclang',
- 'skip-refcounted-dtors'
- ],
- }, {
- 'clang_chrome_plugins_flags': [
- '<@(clang_chrome_plugins_flags)',
- ],
- }],
+ 'clang_chrome_plugins_flags': [
+ '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698