Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempt to fix win Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
diff --git a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
index 3fc661c07b27331e583376cc13612e3b31006e85..648c8ef474df1b41c7249badd9f41e585b9a8853 100644
--- a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
+++ b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
@@ -82,7 +82,7 @@ class SelectFileDialogExtensionBrowserTest : public ExtensionBrowserTest {
virtual void SetUp() OVERRIDE {
// Create the dialog wrapper object, but don't show it yet.
listener_.reset(new MockSelectFileDialogListener());
- dialog_ = new SelectFileDialogExtension(listener_.get());
+ dialog_ = new SelectFileDialogExtension(listener_.get(), NULL);
// We have to provide at least one mount point.
// File manager looks for "Downloads" mount point, so use this name.
@@ -136,7 +136,6 @@ class SelectFileDialogExtensionBrowserTest : public ExtensionBrowserTest {
NULL /* file_types */,
0 /* file_type_index */,
FILE_PATH_LITERAL("") /* default_extension */,
- NULL /* source_contents */,
owning_window,
this /* params */);
@@ -155,7 +154,8 @@ class SelectFileDialogExtensionBrowserTest : public ExtensionBrowserTest {
void TryOpeningSecondDialog(const gfx::NativeWindow& owning_window) {
second_listener_.reset(new MockSelectFileDialogListener());
- second_dialog_ = new SelectFileDialogExtension(second_listener_.get());
+ second_dialog_ = new SelectFileDialogExtension(second_listener_.get(),
+ NULL);
// At the moment we don't really care about dialog type, but we have to put
// some dialog type.
@@ -165,11 +165,8 @@ class SelectFileDialogExtensionBrowserTest : public ExtensionBrowserTest {
NULL /* file_types */,
0 /* file_type_index */,
FILE_PATH_LITERAL("") /* default_extension */,
- NULL /* source_contents */,
owning_window,
this /* params */);
-
-
}
void CloseDialog(DialogButtonType button_type,

Powered by Google App Engine
This is Rietveld 408576698