chrome/browser/ui/views/select_file_dialog_extension_unittest.cc - Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Attempt to fix win Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc ('k') | chrome/browser/ui/views/select_file_dialog_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc b/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

index 30f4f4c8bc7a84cbfe9eb2a7b8308d33a39c89f6..cc405305357718866cf5b8c752b20c2bc9d70b38 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

@@ -13,7 +13,8 @@ class SelectFileDialogExtensionTest : public testing::Test {

static SelectFileDialogExtension* CreateDialog(

SelectFileDialog::Listener* listener,

int32 tab_id) {

- SelectFileDialogExtension* dialog = new SelectFileDialogExtension(listener);

+ SelectFileDialogExtension* dialog = new SelectFileDialogExtension(listener,

+ NULL);

// Simulate the dialog opening.

EXPECT_FALSE(SelectFileDialogExtension::PendingExists(tab_id));

dialog->AddPending(tab_id);