Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2270)

Unified Diff: chrome/browser/extensions/pack_extension_job.h

Issue 10665053: Move ExtensionCreator into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Latest master for cq Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_startup.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/pack_extension_job.h
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h
index f6b99d79db33c977fc4a42555b2800331a162283..be5e867d86ca2750751a70f4bced2166993fffc4 100644
--- a/chrome/browser/extensions/pack_extension_job.h
+++ b/chrome/browser/extensions/pack_extension_job.h
@@ -24,8 +24,9 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
public:
virtual void OnPackSuccess(const FilePath& crx_file,
const FilePath& key_file) = 0;
- virtual void OnPackFailure(const std::string& message,
- ExtensionCreator::ErrorType error_type) = 0;
+ virtual void OnPackFailure(
+ const std::string& message,
+ extensions::ExtensionCreator::ErrorType error_type) = 0;
protected:
virtual ~Client() {}
@@ -57,8 +58,9 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
// If |asynchronous_| is false, this is run on whichever thread calls it.
void Run();
void ReportSuccessOnClientThread();
- void ReportFailureOnClientThread(const std::string& error,
- ExtensionCreator::ErrorType error_type);
+ void ReportFailureOnClientThread(
+ const std::string& error,
+ extensions::ExtensionCreator::ErrorType error_type);
content::BrowserThread::ID client_thread_id_;
Client* client_;
« no previous file with comments | « chrome/browser/extensions/extensions_startup.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698