chrome/browser/extensions/pack_extension_job.cc - Issue 10665053: Move ExtensionCreator into extensions namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 10665053: Move ExtensionCreator into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Latest master for cq Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/pack_extension_job.cc

diff --git a/chrome/browser/extensions/pack_extension_job.cc b/chrome/browser/extensions/pack_extension_job.cc

index 93152a70b9c30ab8895f4812673ef5dbb6b5ead8..a4c8823ebe8e22ce41dbbb8ca4add591d81650b2 100644

--- a/chrome/browser/extensions/pack_extension_job.cc

+++ b/chrome/browser/extensions/pack_extension_job.cc

@@ -51,7 +51,7 @@ void PackExtensionJob::Run() {

// TODO(aa): Need to internationalize the errors that ExtensionCreator

// returns. See bug 20734.

- ExtensionCreator creator;

+ extensions::ExtensionCreator creator;

if (creator.Run(root_directory_, crx_file_out_, key_file_, key_file_out_,

run_flags_)) {

if (asynchronous_) {

@@ -82,7 +82,7 @@ void PackExtensionJob::ReportSuccessOnClientThread() {

void PackExtensionJob::ReportFailureOnClientThread(

const std::string& error,

- ExtensionCreator::ErrorType error_type) {

+ extensions::ExtensionCreator::ErrorType error_type) {

if (client_)

client_->OnPackFailure(error, error_type);

}