Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 10665053: Move ExtensionCreator into extensions namespace (Closed)

Created:
8 years, 6 months ago by Devlin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionCreator and ExtensionCreatorFilter into extensions namespace BUG=134696, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146134

Patch Set 1 : #

Patch Set 2 : Updated with latest master #

Patch Set 3 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_creator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_creator_filter.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_creator_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_creator_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_startup.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_startup.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Simple refactor; please review when time allows.
8 years, 5 months ago (2012-07-05 20:46:58 UTC) #1
Devlin
On 2012/07/05 20:46:58, D Cronin wrote: > Simple refactor; please review when time allows. Updated ...
8 years, 5 months ago (2012-07-10 22:45:50 UTC) #2
Mihai Parparita -not on Chrome
LGTM
8 years, 5 months ago (2012-07-10 22:56:02 UTC) #3
James Hawkins
lgtm
8 years, 5 months ago (2012-07-11 13:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10665053/7002
8 years, 5 months ago (2012-07-11 15:44:22 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 17:33:44 UTC) #6
Change committed as 146134

Powered by Google App Engine
This is Rietveld 408576698