Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 10665036: Cache Nacl Plugin private interface instead of calling GetnaclInterface on every process launch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/plugin.cc
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index 856b31de7c94fd528465f0949b8153ee1274b1f9..9f05a85dd7b9c9d0f0d746f0b99d604826e0e2d2 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -622,8 +622,7 @@ bool Plugin::LoadNaClModuleCommon(nacl::DescWrapper* wrapper,
}
// Try to start the Chrome IPC-based proxy.
- const PPB_NaCl_Private* ppb_nacl = GetNaclInterface();
- if (ppb_nacl->StartPpapiProxy(pp_instance())) {
+ if (nacl_interface_->StartPpapiProxy(pp_instance())) {
using_ipc_proxy_ = true;
// We need to explicitly schedule this here. It is normally called in
// response to starting the SRPC proxy.
@@ -866,6 +865,7 @@ bool Plugin::Init(uint32_t argc, const char* argn[], const char* argv[]) {
// Sets src property to full manifest URL.
RequestNaClManifest(manifest_url);
}
+ nacl_interface_ = GetNaclInterface();
dmichael (off chromium) 2012/06/25 22:24:18 Since you're in the neighborhood, could you rename
Derek Schuff 2012/06/25 22:33:10 Done.
}
PLUGIN_PRINTF(("Plugin::Init (status=%d)\n", status));
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698