Cache Nacl Plugin private interface instead of calling GetnaclInterface on every process launch

ppapi/native_client/src/trusted/plugin/plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifdef _MSC_VER
 // Do not warn about use of std::copy with raw pointers.
 #pragma warning(disable : 4996)
 #endif
 
 #include "native_client/src/trusted/plugin/plugin.h"
@@ skipping 604 matching lines @@
       new_service_runtime->Start(wrapper,
                                  error_info,
                                  manifest_base_url());
   PLUGIN_PRINTF(("Plugin::LoadNaClModuleCommon (service_runtime_started=%d)\n",
                  service_runtime_started));
   if (!service_runtime_started) {
     return false;
   }
 
   // Try to start the Chrome IPC-based proxy.
-  const PPB_NaCl_Private* ppb_nacl = GetNaclInterface();
-  if (ppb_nacl->StartPpapiProxy(pp_instance())) {
+  if (nacl_interface_->StartPpapiProxy(pp_instance())) {
     using_ipc_proxy_ = true;
     // We need to explicitly schedule this here. It is normally called in
     // response to starting the SRPC proxy.
     CHECK(init_done_cb.pp_completion_callback().func != NULL);
     PLUGIN_PRINTF(("Plugin::LoadNaClModuleCommon, started ipc proxy.\n"));
     pp::Module::Get()->core()->CallOnMainThread(0, init_done_cb, PP_OK);
   }
   return true;
 }
 
@@ skipping 222 matching lines @@
       if (NULL != LookupArgument(kNaClManifestAttribute)) {
         PLUGIN_PRINTF(("Plugin::Init:"
                        " WARNING: 'nacl' property is incorrect. Use 'src'.\n"));
       }
     } else {
       // Issue a GET for the manifest_url.  The manifest file will be parsed to
       // determine the nexe URL.
       // Sets src property to full manifest URL.
       RequestNaClManifest(manifest_url);
     }
+    nacl_interface_ = GetNaclInterface();

[dmichael (off chromium), 2012/06/25 22:24:18]

Since you're in the neighborhood, could you rename to GetNaClInterface?
(note the upper-case C)

[Derek Schuff, 2012/06/25 22:33:10]

Done.

   }
 
   PLUGIN_PRINTF(("Plugin::Init (status=%d)\n", status));
   return status;
 }
 
 
 Plugin::Plugin(PP_Instance pp_instance)
     : pp::InstancePrivate(pp_instance),
       scriptable_plugin_(NULL),
       argc_(-1),
       argn_(NULL),
       argv_(NULL),
       main_subprocess_("main subprocess", NULL, NULL),
       nacl_ready_state_(UNSENT),
       nexe_error_reported_(false),
       wrapper_factory_(NULL),
       last_error_string_(""),
       ppapi_proxy_(NULL),
       enable_dev_interfaces_(false),
       init_time_(0),
       ready_time_(0),
       nexe_size_(0),
       time_of_last_progress_event_(0),
       using_ipc_proxy_(false) {

[dmichael (off chromium), 2012/06/25 22:24:18]

please init nacl_interface_ to NULL.

I'd also suggest calling GetNaClInterface in the body of the constructor, and
maybe doing a CHECK that you get a valid pointer.

[Derek Schuff, 2012/06/25 22:33:10]

Done.

   PLUGIN_PRINTF(("Plugin::Plugin (this=%p, pp_instance=%"
                  NACL_PRId32")\n", static_cast<void*>(this), pp_instance));
   callback_factory_.Initialize(this);
   nexe_downloader_.Initialize(this);
 }
 
 
 Plugin::~Plugin() {
   int64_t shutdown_start = NaClGetTimeOfDayMicroseconds();
 
@@ skipping 1011 matching lines @@
                                           static_cast<uint32_t>(text.size()));
   const PPB_Console_Dev* console_interface =
       static_cast<const PPB_Console_Dev*>(
           module->GetBrowserInterface(PPB_CONSOLE_DEV_INTERFACE));
   console_interface->LogWithSource(pp_instance(), PP_LOGLEVEL_LOG, prefix, str);
   var_interface->Release(prefix);
   var_interface->Release(str);
 }
 
 }  // namespace plugin