chrome/installer/util/chrome_browser_operations.cc - Issue 10665002: Implement installation of the Chrome App Host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_browser_operations.cc

Issue 10665002: Implement installation of the Chrome App Host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: A basic working app host installer/uninstaller. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/chrome_browser_operations.cc

diff --git a/chrome/installer/util/chrome_browser_operations.cc b/chrome/installer/util/chrome_browser_operations.cc

index b1ae844fb3f37cc3f9fb8e892f74a5b6494754e8..07070cc0a3c696ff58d05bef678b923bccae1512 100644

--- a/chrome/installer/util/chrome_browser_operations.cc

+++ b/chrome/installer/util/chrome_browser_operations.cc

@@ -41,6 +41,7 @@ void ChromeBrowserOperations::ReadOptions(

void ChromeBrowserOperations::AddKeyFiles(

const std::set<std::wstring>& options,

std::vector<FilePath>* key_files) const {

+ // TODO(erikwright): If multi, can we omit this?

grt (UTC plus 2) 2012/07/12 18:37:10 see my comment in the app host's operations file

erikwright (departed) 2012/07/16 20:13:11 Decided just to leave it for now.

DCHECK(key_files);

key_files->push_back(FilePath(installer::kChromeDll));

}