Issue 10662039: Add HiDPI assets for the WebUI bookmarks manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10662039: Add HiDPI assets for the WebUI bookmarks manager. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 5 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews), Avi (use Gerrit), flackr, Jói

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add HiDPI assets for the WebUI bookmarks manager. Change common.gypi to pass scale_factors=2x to grit on Mac (as a side effect, the close button on about:settings now looks good). Change bookmark_manager/main.html to type="chrome_html" so that it gets the 2x image auto-treatment that's documented at sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources The icon in the upper left corner of about:bookmarks looks good with this change, but the tree icons don't yet because cr/ui/tree.js needs js code changes to make HiDPI icons work. BUG=134372, 123162 TEST=Open bookmark manager. Almost all images look good in HiDPI. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144305

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, --3 lines)			Patch
M	build/common.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/gritsettings/resource_ids	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

(flackr: Took me a while to figure out the type="chrome_html" part was necessary :-/ You ...

8 years, 6 months ago (2012-06-26 05:24:11 UTC) #1

commit-bot: I haz the power

8 years, 5 months ago (2012-06-26 21:24:59 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10662039/2003

Expand Messages | Collapse Messages