Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp - Issue 10660025: Cleanup dart to string conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp

diff --git a/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp b/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp

index 78b183764ee3e6b3e1618ef0fef2920f9be40e96..370a770222f16af734463d08766e06ac892f3ed5 100644

--- a/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp

+++ b/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp

@@ -45,10 +45,10 @@ PassRefPtr<IDBKey> DartIDBKey::toNative(Dart_Handle handle, Dart_Handle& excepti

}

if (Dart_IsString(handle)) {

- RefPtr<StringImpl> asStringImpl = DartUtilities::toStringImpl(handle, DartUtilities::ConvertNone, exception);

+ DartStringAdapter asString = DartUtilities::dartToString(handle, exception);

if (exception)

return 0;

- return IDBKey::createString(asStringImpl);

+ return IDBKey::createString(asString);

}

// FIXME: Support Date case.