Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp - Issue 10660025: Cleanup dart to string conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/bindings/dart/custom/DartMessageEventCustom.cpp ('k') | Source/WebCore/bindings/dart/custom/DartWebKitCSSMatrixCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp

diff --git a/Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp b/Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp

index 476b8c6d78444caf535d3d7a3be88c0e285e8a5a..f66093584feb920493bb7b35c736528e20d0b2cf 100644

--- a/Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp

+++ b/Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp

@@ -264,11 +264,9 @@ void getExtensionCallback(Dart_NativeArguments args)

Dart_Handle exception = 0;

{

WebGLRenderingContext* context = DartDOMWrapper::receiver<WebGLRenderingContext>(args);

- const ParameterAdapter<String> name(Dart_GetNativeArgument(args, 1));

- if (!name.conversionSuccessful()) {

- exception = name.exception();

+ DartStringAdapter name = DartUtilities::dartToString(Dart_GetNativeArgument(args, 1), exception);

+ if (exception)

goto fail;

- }

WebGLExtension* extension = context->getExtension(name);

Dart_Handle result = webGLExtensionToDart(extension);