Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp
diff --git a/Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp b/Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp
index 2ece02957c9a88a74f83f4da1ec0f6e66c56e09a..0c7fbd2d8a9ccc1f286c21268eead7173648fa56 100644
--- a/Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp
+++ b/Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp
@@ -21,11 +21,10 @@ PassRefPtr<DOMStringList> DartDOMStringList::toNative(Dart_Handle handle, Dart_H
RefPtr<DOMStringList> m_domStringList = DOMStringList::create();
for (size_t i = 0; i < elements.size(); i++) {
- RefPtr<StringImpl> element = DartUtilities::toStringImpl(elements[i], DartUtilities::ConvertNone, exception);
+ DartStringAdapter element = DartUtilities::dartToString(elements[i], exception);
if (exception)
return 0;
- ASSERT(element.get());
- m_domStringList->append(element.get());
+ m_domStringList->append(element);
}
return m_domStringList.release();
}

Powered by Google App Engine
This is Rietveld 408576698