Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: Source/WebCore/bindings/dart/custom/DartWebKitCSSMatrixCustom.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011, Google Inc. 1 // Copyright 2011, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 namespace DartWebKitCSSMatrixInternal { 40 namespace DartWebKitCSSMatrixInternal {
41 41
42 void constructorCallback(Dart_NativeArguments args) 42 void constructorCallback(Dart_NativeArguments args)
43 { 43 {
44 DartApiScope dartApiScope; 44 DartApiScope dartApiScope;
45 Dart_Handle exception = 0; 45 Dart_Handle exception = 0;
46 { 46 {
47 const ParameterAdapter<String> cssValue(Dart_GetNativeArgument(args, 0), DartUtilities::ConvertNullToDefaultValue); 47 DartStringAdapter cssValue = DartUtilities::dartToStringWithNullCheck(Da rt_GetNativeArgument(args, 0), exception);
48 if (!cssValue.conversionSuccessful()) { 48 if (exception)
49 exception = cssValue.exception();
50 goto fail; 49 goto fail;
51 }
52 50
53 ExceptionCode ec = 0; 51 ExceptionCode ec = 0;
54 RefPtr<WebKitCSSMatrix> matrix = WebKitCSSMatrix::create(cssValue, ec); 52 RefPtr<WebKitCSSMatrix> matrix = WebKitCSSMatrix::create(cssValue, ec);
55 if (UNLIKELY(ec)) { 53 if (UNLIKELY(ec)) {
56 exception = DartDOMWrapper::exceptionCodeToDartException(ec); 54 exception = DartDOMWrapper::exceptionCodeToDartException(ec);
57 goto fail; 55 goto fail;
58 } 56 }
59 57
60 DartDOMWrapper::returnValue<DartWebKitCSSMatrix>(args, matrix.release()) ; 58 DartDOMWrapper::returnValue<DartWebKitCSSMatrix>(args, matrix.release()) ;
61 return; 59 return;
62 } 60 }
63 61
64 fail: 62 fail:
65 Dart_ThrowException(exception); 63 Dart_ThrowException(exception);
66 ASSERT_NOT_REACHED(); 64 ASSERT_NOT_REACHED();
67 } 65 }
68 66
69 } // DartWebKitCSSMatrixInternal 67 } // DartWebKitCSSMatrixInternal
70 68
71 } // WebCore 69 } // WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698