Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/WebCore/bindings/dart/DartDebugServer.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 ASSERT(!Dart_IsError(libraryIdHandle)); 464 ASSERT(!Dart_IsError(libraryIdHandle));
465 Dart_Handle exception = 0; 465 Dart_Handle exception = 0;
466 int64_t int64LibraryId = DartUtilities::toInteger(libraryIdHandle, excep tion); 466 int64_t int64LibraryId = DartUtilities::toInteger(libraryIdHandle, excep tion);
467 ASSERT(!exception); 467 ASSERT(!exception);
468 intptr_t libraryId = static_cast<intptr_t>(int64LibraryId); 468 intptr_t libraryId = static_cast<intptr_t>(int64LibraryId);
469 ASSERT(libraryId == int64LibraryId); 469 ASSERT(libraryId == int64LibraryId);
470 470
471 Dart_Handle libraryURL = Dart_GetLibraryURL(libraryId); 471 Dart_Handle libraryURL = Dart_GetLibraryURL(libraryId);
472 ASSERT(Dart_IsString(libraryURL)); 472 ASSERT(Dart_IsString(libraryURL));
473 473
474 if (ignoreStandardLibraries && DartUtilities::dartStringToString(library URL).startsWith("dart:")) 474 if (ignoreStandardLibraries && DartUtilities::toString(libraryURL).start sWith("dart:"))
475 continue; 475 continue;
476 476
477 Dart_Handle scripts = Dart_GetScriptURLs(libraryURL); 477 Dart_Handle scripts = Dart_GetScriptURLs(libraryURL);
478 ASSERT(Dart_IsList(scripts)); 478 ASSERT(Dart_IsList(scripts));
479 479
480 intptr_t scriptsLength = 0; 480 intptr_t scriptsLength = 0;
481 result = Dart_ListLength(scripts, &scriptsLength); 481 result = Dart_ListLength(scripts, &scriptsLength);
482 ASSERT(!Dart_IsError(result)); 482 ASSERT(!Dart_IsError(result));
483 for (intptr_t j = 0; j < scriptsLength; ++j) { 483 for (intptr_t j = 0; j < scriptsLength; ++j) {
484 Dart_Handle scriptURL = Dart_ListGetAt(scripts, j); 484 Dart_Handle scriptURL = Dart_ListGetAt(scripts, j);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 nativeCallbacks->Set(v8::String::New("setBreakpoint"), v8::FunctionTemplate: :New(&setBreakpoint)->GetFunction()); 592 nativeCallbacks->Set(v8::String::New("setBreakpoint"), v8::FunctionTemplate: :New(&setBreakpoint)->GetFunction());
593 nativeCallbacks->Set(v8::String::New("removeBreakpoint"), v8::FunctionTempla te::New(&removeBreakpoint)->GetFunction()); 593 nativeCallbacks->Set(v8::String::New("removeBreakpoint"), v8::FunctionTempla te::New(&removeBreakpoint)->GetFunction());
594 nativeCallbacks->Set(v8::String::New("getBreakpointLine"), v8::FunctionTempl ate::New(&getBreakpointLine)->GetFunction()); 594 nativeCallbacks->Set(v8::String::New("getBreakpointLine"), v8::FunctionTempl ate::New(&getBreakpointLine)->GetFunction());
595 nativeCallbacks->Set(v8::String::New("setExceptionPauseInfo"), v8::FunctionT emplate::New(&setExceptionPauseInfo)->GetFunction()); 595 nativeCallbacks->Set(v8::String::New("setExceptionPauseInfo"), v8::FunctionT emplate::New(&setExceptionPauseInfo)->GetFunction());
596 nativeCallbacks->Set(v8::String::New("stepInto"), v8::FunctionTemplate::New( &stepInto)->GetFunction()); 596 nativeCallbacks->Set(v8::String::New("stepInto"), v8::FunctionTemplate::New( &stepInto)->GetFunction());
597 nativeCallbacks->Set(v8::String::New("stepOver"), v8::FunctionTemplate::New( &stepOver)->GetFunction()); 597 nativeCallbacks->Set(v8::String::New("stepOver"), v8::FunctionTemplate::New( &stepOver)->GetFunction());
598 nativeCallbacks->Set(v8::String::New("stepOut"), v8::FunctionTemplate::New(& stepOut)->GetFunction()); 598 nativeCallbacks->Set(v8::String::New("stepOut"), v8::FunctionTemplate::New(& stepOut)->GetFunction());
599 } 599 }
600 600
601 } 601 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698