Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10660021: HiDPI assets for omnibox icons. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Aaron Boodman, James Su, mihaip-chromium-reviews_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

HiDPI assets for omnibox icons. Remove pdf files on Mac and use 2x pngs in the omnibox. Side effect: The default favicon is now an empty page instead of a globe. BUG=134372, 111101 TEST=icons in omnibox are hidpi and generally match the look on non-mac platforms. TBR=avi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144334

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : win/gtk #

Patch Set 4 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -7237 lines) Patch
M chrome/app/theme/default_100_percent/blocked_cookies.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/blocked_images.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/blocked_plugins.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/blocked_popups.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/blocked_script.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_extension_app.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_extension_app_selected.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_http.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_http_dark.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_http_selected.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_https_invalid.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_https_valid.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_https_warning.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_search.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_star.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/omnibox_tts.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/star_lit.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/blocked_cookies.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/blocked_images.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/blocked_plugins.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/blocked_popups.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/blocked_script.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_extension_app.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_http.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_http_selected.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_https_invalid.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_https_valid.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_https_warning.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_search.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_star.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/omnibox_tts.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/star_lit.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/omnibox_extension_app.pdf View 1 2 3 1 chunk +3 lines, -1551 lines 0 comments Download
D chrome/app/theme/omnibox_http.pdf View 1 2 3 1 chunk +4 lines, -1603 lines 0 comments Download
D chrome/app/theme/omnibox_https_invalid.pdf View 1 2 3 1 chunk +1 line, -307 lines 0 comments Download
D chrome/app/theme/omnibox_https_valid.pdf View 1 2 3 1 chunk +0 lines, -465 lines 0 comments Download
D chrome/app/theme/omnibox_https_warning.pdf View 1 2 3 1 chunk +0 lines, -341 lines 0 comments Download
D chrome/app/theme/omnibox_search.pdf View 1 2 3 1 chunk +3 lines, -1442 lines 0 comments Download
D chrome/app/theme/omnibox_tts.pdf View 1 2 3 1 chunk +1 line, -1514 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/app_list/search_builder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M ui/resources/default_100_percent/default_favicon.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/default_large_favicon.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/default_favicon.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
8 years, 5 months ago (2012-06-26 23:17:15 UTC) #1
Nico
I'll tbr this, as it's just new assets.
8 years, 5 months ago (2012-06-26 23:23:35 UTC) #2
Avi (use Gerrit)
8 years, 5 months ago (2012-06-27 03:43:41 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698