Revert 144071 - Add a regenerate button to regenerate the password in Windows.

Revert 144071 - Add a regenerate button to regenerate the password in Windows.


BUG=120480
TEST=Not tested.


Review URL: https://chromiumcodereview.appspot.com/10642009

TBR=zysxqn@google.com
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144074

[zysxqn, 2012-06-26 16:45:20]

Hi John,

   I saw this issue is closed. Just want to double check is it because you
have submitted this revert (in this case I need to re-submit my change
again) or because you find other way to work around it?

Thanks,
Yue

On Mon, Jun 25, 2012 at 5:39 PM, <jam@chromium.org> wrote:

> Reviewers: zysxqn,
>
> Description:
> Revert 144071 - Add a regenerate button to regenerate the password in
> Windows.
>
>
> BUG=120480
> TEST=Not tested.
>
>
> Review URL:
https://chromiumcodereview.**appspot.com/10642009<https://chromiumcodereview....
>
> TBR=zysxqn@google.com
>
> Please review this at
https://chromiumcodereview.**appspot.com/10659022/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     chrome/browser/ui/views/frame/**browser_view.cc
>  M     chrome/browser/ui/views/**password_generation_bubble_**view.h
>  M     chrome/browser/ui/views/**password_generation_bubble_**view.cc
>  A  +  rlz/DEPS
>  A  +  rlz/OWNERS
>  A  +  rlz/lib/assert.h
>  A  +  rlz/lib/assert.cc
>  A  +  rlz/lib/crc32.h
>  A  +  rlz/lib/crc32_unittest.cc
>  A  +  rlz/lib/crc32_wrapper.cc
>  A  +  rlz/lib/crc8.h
>  A  +  rlz/lib/crc8.cc
>  A  +  rlz/lib/crc8_unittest.cc
>  A  +  rlz/lib/financial_ping.h
>  A  +  rlz/lib/financial_ping.cc
>  A  +  rlz/lib/financial_ping_test.cc
>  A  +  rlz/lib/lib_values.h
>  A  +  rlz/lib/lib_values.cc
>  A  +  rlz/lib/lib_values_unittest.cc
>  A  +  rlz/lib/machine_id.h
>  A  +  rlz/lib/machine_id.cc
>  A  +  rlz/lib/machine_id_unittest.cc
>  A  +  rlz/lib/rlz_enums.h
>  A  +  rlz/lib/rlz_lib.h
>  A  +  rlz/lib/rlz_lib.cc
>  A  +  rlz/lib/rlz_lib_clear.cc
>  A  +  rlz/lib/rlz_lib_test.cc
>  A  +  rlz/lib/rlz_value_store.h
>  A  +  rlz/lib/string_utils.h
>  A  +  rlz/lib/string_utils.cc
>  A  +  rlz/lib/string_utils_unittest.**cc
>  A  +  rlz/mac/lib/machine_id_mac.cc
>  A  +  rlz/mac/lib/rlz_value_store_**mac.h
>  A  +  rlz/mac/lib/rlz_value_store_**mac.mm<http://rlz_value_store_mac.mm>
>  A  +  rlz/rlz.gyp
>  A  +  rlz/test/rlz_test_helpers.h
>  A  +  rlz/test/rlz_test_helpers.cc
>  A  +  rlz/test/rlz_unittest_main.cc
>  A  +  rlz/win/dll/dll_main.cc
>  A  +  rlz/win/dll/exports.cc
>  A  +  rlz/win/lib/lib_mutex.h
>  A  +  rlz/win/lib/lib_mutex.cc
>  A  +  rlz/win/lib/machine_deal.h
>  A  +  rlz/win/lib/machine_deal.cc
>  A  +  rlz/win/lib/machine_deal_test.**cc
>  A  +  rlz/win/lib/machine_id_win.cc
>  A  +  rlz/win/lib/process_info.h
>  A  +  rlz/win/lib/process_info.cc
>  A  +  rlz/win/lib/registry_util.h
>  A  +  rlz/win/lib/registry_util.cc
>  A  +  rlz/win/lib/rlz_lib.h
>  A  +  rlz/win/lib/rlz_lib_win.cc
>  A  +  rlz/win/lib/rlz_value_store_**registry.h
>  A  +  rlz/win/lib/rlz_value_store_**registry.cc
>  A  +  rlz/win/lib/vista_winnt.h
>
>
> ### BEGIN SVN COPY METADATA
> #$ cp trunk/src/rlz/test/rlz_**unittest_main.cc
> rlz\test\rlz_unittest_main.cc
> #$ cp trunk/src/rlz/lib/lib_values.h rlz\lib\lib_values.h
> #$ cp trunk/src/rlz/rlz.gyp rlz\rlz.gyp
> #$ cp trunk/src/rlz/lib/rlz_lib.cc rlz\lib\rlz_lib.cc
> #$ cp trunk/src/rlz/win/lib/rlz_lib_**win.cc rlz\win\lib\rlz_lib_win.cc
> #$ cp trunk/src/rlz/win/lib/**registry_util.h rlz\win\lib\registry_util.h
> #$ cp
trunk/src/rlz/mac/lib/rlz_**value_store_mac.mm<http://rlz_value_store_mac.mm>rlz\mac\lib\
> rlz_value_store_**mac.mm <http://rlz_value_store_mac.mm>
> #$ cp trunk/src/rlz/mac/lib/rlz_**value_store_mac.h
> rlz\mac\lib\rlz_value_store_**mac.h
> #$ cp trunk/src/rlz/win/lib/machine_**deal.h rlz\win\lib\machine_deal.h
> #$ cp trunk/src/rlz/lib/assert.cc rlz\lib\assert.cc
> #$ cp trunk/src/rlz/win/dll/exports.**cc rlz\win\dll\exports.cc
> #$ cp trunk/src/rlz/lib/crc8.cc rlz\lib\crc8.cc
> #$ cp trunk/src/rlz/lib/financial_**ping.h rlz\lib\financial_ping.h
> #$ cp trunk/src/rlz/lib/string_**utils.cc rlz\lib\string_utils.cc
> #$ cp trunk/src/rlz/lib/crc32_**unittest.cc rlz\lib\crc32_unittest.cc
> #$ cp trunk/src/rlz/test/rlz_test_**helpers.cc
> rlz\test\rlz_test_helpers.cc
> #$ cp trunk/src/rlz/win/lib/rlz_**value_store_registry.h
> rlz\win\lib\rlz_value_store_**registry.h
> #$ cp trunk/src/rlz/win/lib/process_**info.h rlz\win\lib\process_info.h
> #$ cp trunk/src/rlz/win/lib/rlz_**value_store_registry.cc
> rlz\win\lib\rlz_value_store_**registry.cc
> #$ cp trunk/src/rlz/lib/machine_id.**cc rlz\lib\machine_id.cc
> #$ cp trunk/src/rlz/lib/crc8.h rlz\lib\crc8.h
> #$ cp trunk/src/rlz/test/rlz_test_**helpers.h rlz\test\rlz_test_helpers.h
> #$ cp trunk/src/rlz/OWNERS rlz\OWNERS
> #$ cp trunk/src/rlz/lib/rlz_lib.h rlz\lib\rlz_lib.h
> #$ cp trunk/src/rlz/lib/rlz_value_**store.h rlz\lib\rlz_value_store.h
> #$ cp trunk/src/rlz/win/lib/**registry_util.cc
> rlz\win\lib\registry_util.cc
> #$ cp trunk/src/rlz/lib/assert.h rlz\lib\assert.h
> #$ cp trunk/src/rlz/lib/crc32.h rlz\lib\crc32.h
> #$ cp trunk/src/rlz/lib/machine_id.h rlz\lib\machine_id.h
> #$ cp trunk/src/rlz/win/dll/dll_**main.cc rlz\win\dll\dll_main.cc
> #$ cp trunk/src/rlz/lib/crc8_**unittest.cc rlz\lib\crc8_unittest.cc
> #$ cp trunk/src/rlz/lib/financial_**ping_test.cc
> rlz\lib\financial_ping_test.cc
> #$ cp trunk/src/rlz/win/lib/rlz_lib.**h rlz\win\lib\rlz_lib.h
> #$ cp trunk/src/rlz/win/lib/machine_**deal_test.cc
> rlz\win\lib\machine_deal_test.**cc
> #$ cp trunk/src/rlz/win/lib/lib_**mutex.cc rlz\win\lib\lib_mutex.cc
> #$ cp trunk/src/rlz/DEPS rlz\DEPS
> #$ cp trunk/src/rlz/lib/rlz_lib_**test.cc rlz\lib\rlz_lib_test.cc
> #$ cp trunk/src/rlz/lib/rlz_enums.h rlz\lib\rlz_enums.h
> #$ cp trunk/src/rlz/lib/lib_values_**unittest.cc
> rlz\lib\lib_values_unittest.cc
> #$ cp trunk/src/rlz/win/lib/machine_**id_win.cc
> rlz\win\lib\machine_id_win.cc
> #$ cp trunk/src/rlz/win/lib/process_**info.cc rlz\win\lib\process_info.cc
> #$ cp trunk/src/rlz/lib/financial_**ping.cc rlz\lib\financial_ping.cc
> #$ cp trunk/src/rlz/lib/lib_values.**cc rlz\lib\lib_values.cc
> #$ cp trunk/src/rlz/lib/string_**utils.h rlz\lib\string_utils.h
> #$ cp trunk/src/rlz/mac/lib/machine_**id_mac.cc
> rlz\mac\lib\machine_id_mac.cc
> #$ cp trunk/src/rlz/lib/string_**utils_unittest.cc
> rlz\lib\string_utils_unittest.**cc
> #$ cp trunk/src/rlz/lib/machine_id_**unittest.cc
> rlz\lib\machine_id_unittest.cc
> #$ cp trunk/src/rlz/lib/crc32_**wrapper.cc rlz\lib\crc32_wrapper.cc
> #$ cp trunk/src/rlz/win/lib/machine_**deal.cc rlz\win\lib\machine_deal.cc
> #$ cp trunk/src/rlz/win/lib/vista_**winnt.h rlz\win\lib\vista_winnt.h
> #$ cp trunk/src/rlz/win/lib/lib_**mutex.h rlz\win\lib\lib_mutex.h
> #$ cp trunk/src/rlz/lib/rlz_lib_**clear.cc rlz\lib\rlz_lib_clear.cc
> ### END SVN COPY METADATA
> Index: chrome/browser/ui/views/frame/**browser_view.cc
> ==============================**==============================**=======
> --- chrome/browser/ui/views/frame/**browser_view.cc       (revision
> 144073)
> +++ chrome/browser/ui/views/frame/**browser_view.cc       (working copy)
> @@ -2487,8 +2487,6 @@
>     const gfx::Rect& rect,
>     autofill::PasswordGenerator* password_generator,
>     const webkit::forms::PasswordForm& form) {
> -  ui::ThemeProvider* theme_provider = GetWidget()->GetThemeProvider(**);
> -
>   // Create a rect in the content bounds that the bubble will point to.
>   gfx::Point origin(rect.origin());
>   views::View::**ConvertPointToScreen(**GetTabContentsContainerView(),
> &origin);
> @@ -2507,8 +2505,7 @@
>           tab_contents->web_contents()->**GetRenderViewHost(),
>           password_generator,
>           browser_.get(),
> -          tab_contents->password_**manager(),
> -          theme_provider);
> +          tab_contents->password_**manager());
>
>   views::BubbleDelegateView::**CreateBubble(bubble);
>   bubble->SetAlignment(views::**BubbleBorder::ALIGN_ARROW_TO_**
> MID_ANCHOR);
> Index: chrome/browser/ui/views/**password_generation_bubble_**view.cc
> ==============================**==============================**=======
> --- chrome/browser/ui/views/**password_generation_bubble_**view.cc
>  (revision 144073)
> +++ chrome/browser/ui/views/**password_generation_bubble_**view.cc
>  (working copy)
> @@ -15,10 +15,7 @@
>  #include "content/public/browser/**render_view_host.h"
>  #include "googleurl/src/gurl.h"
>  #include "grit/generated_resources.h"
> -#include "grit/theme_resources_**standard.h"
> -#include "ui/base/theme_provider.h"
>  #include "ui/base/l10n/l10n_util.h"
> -#include "ui/views/controls/button/**image_button.h"
>  #include "ui/views/controls/button/**text_button.h"
>  #include "ui/views/controls/label.h"
>  #include "ui/views/controls/link.h"
> @@ -36,19 +33,16 @@
>     content::RenderViewHost* render_view_host,
>     autofill::PasswordGenerator* password_generator,
>     content::PageNavigator* navigator,
> -    PasswordManager* password_manager,
> -    ui::ThemeProvider* theme_provider)
> +    PasswordManager* password_manager)
>     : BubbleDelegateView(anchor_**view, views::BubbleBorder::TOP_LEFT)**,
>       accept_button_(NULL),
> -      regenerate_button_(NULL),
>       text_field_(NULL),
>       anchor_rect_(anchor_rect),
>       form_(form),
>       render_view_host_(render_view_**host),
>       password_generator_(password_**generator),
>       navigator_(navigator),
> -      password_manager_(password_**manager),
> -      theme_provider_(theme_**provider) {}
> +      password_manager_(password_**manager) {}
>
>  PasswordGenerationBubbleView::**~PasswordGenerationBubbleView(**) {}
>
> @@ -58,15 +52,6 @@
>   accept_button_ = new views::NativeTextButton(this,
>                                                ASCIIToUTF16("Try It"));
>
> -  regenerate_button_ = new views::ImageButton(this);
> -  regenerate_button_->SetImage(**views::CustomButton::BS_**NORMAL,
> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD))**;
> -  regenerate_button_->SetImage(**views::CustomButton::BS_HOT,
> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD_**H));
> -  regenerate_button_->SetImage(**views::CustomButton::BS_**PUSHED,
> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD_**P));
> -  regenerate_button_->**SetTooltipText(ASCIIToUTF16("**Regenerate"));
> -
>   text_field_ = new views::Textfield();
>   text_field_->SetText(
>       ASCIIToUTF16(password_**generator_->Generate()));
> @@ -94,8 +79,6 @@
>   cs = layout->AddColumnSet(1);
>   cs->AddColumn(GridLayout::**FILL, GridLayout::CENTER, 0,
>                 GridLayout::USE_PREF, 0, 100);
> -  cs->AddColumn(GridLayout::**FILL, GridLayout::CENTER, 0,
> GridLayout::FIXED,
> -                regenerate_button_->**GetPreferredSize().width(), 100);
>   cs->AddPaddingColumn(1, views::**kRelatedControlHorizontalSpaci**ng);
>   cs->AddColumn(GridLayout::**TRAILING, GridLayout::CENTER, 0,
>                 GridLayout::USE_PREF, 0, 0);
> @@ -106,7 +89,6 @@
>
>   layout->StartRow(0, 1);
>   layout->AddView(text_field_);
> -  layout->AddView(regenerate_**button_);
>   layout->AddView(accept_button_**);
>  }
>
> @@ -121,9 +103,6 @@
>         render_view_host_->**GetRoutingID(), text_field_->text()));
>     password_manager_->**SetFormHasGeneratedPassword(**form_);
>     StartFade(false);
> -  } else if (sender == regenerate_button_) {
> -    text_field_->SetText(
> -        ASCIIToUTF16(password_**generator_->Generate()));
>   }
>  }
>
> Index: chrome/browser/ui/views/**password_generation_bubble_**view.h
> ==============================**==============================**=======
> --- chrome/browser/ui/views/**password_generation_bubble_**view.h
> (revision 144073)
> +++ chrome/browser/ui/views/**password_generation_bubble_**view.h
> (working copy)
> @@ -24,7 +24,6 @@
>  }
>
>  namespace views {
> -class ImageButton;
>  class TextButton;
>  class Textfield;
>  }
> @@ -45,8 +44,7 @@
>                                content::RenderViewHost* render_view_host,
>                                autofill::PasswordGenerator*
> password_generator,
>                                content::PageNavigator* navigator,
> -                               PasswordManager* password_manager,
> -                               ui::ThemeProvider* theme_provider);
> +                               PasswordManager* password_manager);
>   virtual ~PasswordGenerationBubbleView(**);
>
>  private:
> @@ -66,7 +64,6 @@
>
>   // Subviews
>   views::TextButton* accept_button_;
> -  views::ImageButton* regenerate_button_;
>   views::Textfield* text_field_;
>
>   // Location that the bubble points to
> @@ -88,9 +85,6 @@
>   // PasswordManager associated with this tab.
>   PasswordManager* password_manager_;
>
> -  // Theme provider used to draw the regenerate button.
> -  ui::ThemeProvider* theme_provider_;
> -
>   DISALLOW_COPY_AND_ASSIGN(**PasswordGenerationBubbleView);
>  };
>
>
> Property changes on: rlz\DEPS
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\OWNERS
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\assert.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\assert.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc32.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc32_unittest.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc32_wrapper.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc8.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc8.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\crc8_unittest.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\financial_ping.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\financial_ping.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\financial_ping_test.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\lib_values.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\lib_values.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\lib_values_unittest.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\machine_id.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\machine_id.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\machine_id_unittest.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_enums.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_lib.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_lib.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_lib_clear.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_lib_test.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\rlz_value_store.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\string_utils.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\string_utils.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\lib\string_utils_unittest.**cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\mac\lib\machine_id_mac.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\mac\lib\rlz_value_store_**mac.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on:
rlz\mac\lib\rlz_value_store_**mac.mm<http://rlz_value_store_mac.mm>
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\rlz.gyp
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\test\rlz_test_helpers.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\test\rlz_test_helpers.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\test\rlz_unittest_main.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\dll\dll_main.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\dll\exports.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\lib_mutex.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\lib_mutex.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\machine_deal.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\machine_deal.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\machine_deal_test.**cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\machine_id_win.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\process_info.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\process_info.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\registry_util.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\registry_util.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\rlz_lib.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\rlz_lib_win.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\rlz_value_store_**registry.cc
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\rlz_value_store_**registry.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
> Property changes on: rlz\win\lib\vista_winnt.h
> ______________________________**______________________________**_______
> Added: svn:mergeinfo
>
>
>
>

[jam, 2012-06-26 23:27:54]

It's closed because the change has been committed (see
http://src.chromium.org/viewvc/chrome?view=rev&revision=144071 in the
description).

So yes, you need to submit your change again (without the rlz part).


On Tue, Jun 26, 2012 at 9:45 AM, Yue Zhang <zysxqn@google.com> wrote:

> Hi John,
>
>    I saw this issue is closed. Just want to double check is it because you
> have submitted this revert (in this case I need to re-submit my change
> again) or because you find other way to work around it?
>
> Thanks,
> Yue
>
>
> On Mon, Jun 25, 2012 at 5:39 PM, <jam@chromium.org> wrote:
>
>> Reviewers: zysxqn,
>>
>> Description:
>> Revert 144071 - Add a regenerate button to regenerate the password in
>> Windows.
>>
>>
>> BUG=120480
>> TEST=Not tested.
>>
>>
>> Review URL:
https://chromiumcodereview.**appspot.com/10642009<https://chromiumcodereview....
>>
>> TBR=zysxqn@google.com
>>
>> Please review this at
https://chromiumcodereview.**appspot.com/10659022/<https://chromiumcodereview...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>>
>> Affected files:
>>  M     chrome/browser/ui/views/frame/**browser_view.cc
>>  M     chrome/browser/ui/views/**password_generation_bubble_**view.h
>>  M     chrome/browser/ui/views/**password_generation_bubble_**view.cc
>>  A  +  rlz/DEPS
>>  A  +  rlz/OWNERS
>>  A  +  rlz/lib/assert.h
>>  A  +  rlz/lib/assert.cc
>>  A  +  rlz/lib/crc32.h
>>  A  +  rlz/lib/crc32_unittest.cc
>>  A  +  rlz/lib/crc32_wrapper.cc
>>  A  +  rlz/lib/crc8.h
>>  A  +  rlz/lib/crc8.cc
>>  A  +  rlz/lib/crc8_unittest.cc
>>  A  +  rlz/lib/financial_ping.h
>>  A  +  rlz/lib/financial_ping.cc
>>  A  +  rlz/lib/financial_ping_test.cc
>>  A  +  rlz/lib/lib_values.h
>>  A  +  rlz/lib/lib_values.cc
>>  A  +  rlz/lib/lib_values_unittest.cc
>>  A  +  rlz/lib/machine_id.h
>>  A  +  rlz/lib/machine_id.cc
>>  A  +  rlz/lib/machine_id_unittest.cc
>>  A  +  rlz/lib/rlz_enums.h
>>  A  +  rlz/lib/rlz_lib.h
>>  A  +  rlz/lib/rlz_lib.cc
>>  A  +  rlz/lib/rlz_lib_clear.cc
>>  A  +  rlz/lib/rlz_lib_test.cc
>>  A  +  rlz/lib/rlz_value_store.h
>>  A  +  rlz/lib/string_utils.h
>>  A  +  rlz/lib/string_utils.cc
>>  A  +  rlz/lib/string_utils_unittest.**cc
>>  A  +  rlz/mac/lib/machine_id_mac.cc
>>  A  +  rlz/mac/lib/rlz_value_store_**mac.h
>>  A  +  rlz/mac/lib/rlz_value_store_**mac.mm<http://rlz_value_store_mac.mm>
>>  A  +  rlz/rlz.gyp
>>  A  +  rlz/test/rlz_test_helpers.h
>>  A  +  rlz/test/rlz_test_helpers.cc
>>  A  +  rlz/test/rlz_unittest_main.cc
>>  A  +  rlz/win/dll/dll_main.cc
>>  A  +  rlz/win/dll/exports.cc
>>  A  +  rlz/win/lib/lib_mutex.h
>>  A  +  rlz/win/lib/lib_mutex.cc
>>  A  +  rlz/win/lib/machine_deal.h
>>  A  +  rlz/win/lib/machine_deal.cc
>>  A  +  rlz/win/lib/machine_deal_test.**cc
>>  A  +  rlz/win/lib/machine_id_win.cc
>>  A  +  rlz/win/lib/process_info.h
>>  A  +  rlz/win/lib/process_info.cc
>>  A  +  rlz/win/lib/registry_util.h
>>  A  +  rlz/win/lib/registry_util.cc
>>  A  +  rlz/win/lib/rlz_lib.h
>>  A  +  rlz/win/lib/rlz_lib_win.cc
>>  A  +  rlz/win/lib/rlz_value_store_**registry.h
>>  A  +  rlz/win/lib/rlz_value_store_**registry.cc
>>  A  +  rlz/win/lib/vista_winnt.h
>>
>>
>> ### BEGIN SVN COPY METADATA
>> #$ cp trunk/src/rlz/test/rlz_**unittest_main.cc
>> rlz\test\rlz_unittest_main.cc
>> #$ cp trunk/src/rlz/lib/lib_values.h rlz\lib\lib_values.h
>> #$ cp trunk/src/rlz/rlz.gyp rlz\rlz.gyp
>> #$ cp trunk/src/rlz/lib/rlz_lib.cc rlz\lib\rlz_lib.cc
>> #$ cp trunk/src/rlz/win/lib/rlz_lib_**win.cc rlz\win\lib\rlz_lib_win.cc
>> #$ cp trunk/src/rlz/win/lib/**registry_util.h rlz\win\lib\registry_util.h
>> #$ cp
trunk/src/rlz/mac/lib/rlz_**value_store_mac.mm<http://rlz_value_store_mac.mm>rlz\mac\lib\
>> rlz_value_store_**mac.mm <http://rlz_value_store_mac.mm>
>> #$ cp trunk/src/rlz/mac/lib/rlz_**value_store_mac.h
>> rlz\mac\lib\rlz_value_store_**mac.h
>> #$ cp trunk/src/rlz/win/lib/machine_**deal.h rlz\win\lib\machine_deal.h
>> #$ cp trunk/src/rlz/lib/assert.cc rlz\lib\assert.cc
>> #$ cp trunk/src/rlz/win/dll/exports.**cc rlz\win\dll\exports.cc
>> #$ cp trunk/src/rlz/lib/crc8.cc rlz\lib\crc8.cc
>> #$ cp trunk/src/rlz/lib/financial_**ping.h rlz\lib\financial_ping.h
>> #$ cp trunk/src/rlz/lib/string_**utils.cc rlz\lib\string_utils.cc
>> #$ cp trunk/src/rlz/lib/crc32_**unittest.cc rlz\lib\crc32_unittest.cc
>> #$ cp trunk/src/rlz/test/rlz_test_**helpers.cc
>> rlz\test\rlz_test_helpers.cc
>> #$ cp trunk/src/rlz/win/lib/rlz_**value_store_registry.h
>> rlz\win\lib\rlz_value_store_**registry.h
>> #$ cp trunk/src/rlz/win/lib/process_**info.h rlz\win\lib\process_info.h
>> #$ cp trunk/src/rlz/win/lib/rlz_**value_store_registry.cc
>> rlz\win\lib\rlz_value_store_**registry.cc
>> #$ cp trunk/src/rlz/lib/machine_id.**cc rlz\lib\machine_id.cc
>> #$ cp trunk/src/rlz/lib/crc8.h rlz\lib\crc8.h
>> #$ cp trunk/src/rlz/test/rlz_test_**helpers.h rlz\test\rlz_test_helpers.h
>> #$ cp trunk/src/rlz/OWNERS rlz\OWNERS
>> #$ cp trunk/src/rlz/lib/rlz_lib.h rlz\lib\rlz_lib.h
>> #$ cp trunk/src/rlz/lib/rlz_value_**store.h rlz\lib\rlz_value_store.h
>> #$ cp trunk/src/rlz/win/lib/**registry_util.cc
>> rlz\win\lib\registry_util.cc
>> #$ cp trunk/src/rlz/lib/assert.h rlz\lib\assert.h
>> #$ cp trunk/src/rlz/lib/crc32.h rlz\lib\crc32.h
>> #$ cp trunk/src/rlz/lib/machine_id.h rlz\lib\machine_id.h
>> #$ cp trunk/src/rlz/win/dll/dll_**main.cc rlz\win\dll\dll_main.cc
>> #$ cp trunk/src/rlz/lib/crc8_**unittest.cc rlz\lib\crc8_unittest.cc
>> #$ cp trunk/src/rlz/lib/financial_**ping_test.cc
>> rlz\lib\financial_ping_test.cc
>> #$ cp trunk/src/rlz/win/lib/rlz_lib.**h rlz\win\lib\rlz_lib.h
>> #$ cp trunk/src/rlz/win/lib/machine_**deal_test.cc
>> rlz\win\lib\machine_deal_test.**cc
>> #$ cp trunk/src/rlz/win/lib/lib_**mutex.cc rlz\win\lib\lib_mutex.cc
>> #$ cp trunk/src/rlz/DEPS rlz\DEPS
>> #$ cp trunk/src/rlz/lib/rlz_lib_**test.cc rlz\lib\rlz_lib_test.cc
>> #$ cp trunk/src/rlz/lib/rlz_enums.h rlz\lib\rlz_enums.h
>> #$ cp trunk/src/rlz/lib/lib_values_**unittest.cc
>> rlz\lib\lib_values_unittest.cc
>> #$ cp trunk/src/rlz/win/lib/machine_**id_win.cc
>> rlz\win\lib\machine_id_win.cc
>> #$ cp trunk/src/rlz/win/lib/process_**info.cc rlz\win\lib\process_info.cc
>> #$ cp trunk/src/rlz/lib/financial_**ping.cc rlz\lib\financial_ping.cc
>> #$ cp trunk/src/rlz/lib/lib_values.**cc rlz\lib\lib_values.cc
>> #$ cp trunk/src/rlz/lib/string_**utils.h rlz\lib\string_utils.h
>> #$ cp trunk/src/rlz/mac/lib/machine_**id_mac.cc
>> rlz\mac\lib\machine_id_mac.cc
>> #$ cp trunk/src/rlz/lib/string_**utils_unittest.cc
>> rlz\lib\string_utils_unittest.**cc
>> #$ cp trunk/src/rlz/lib/machine_id_**unittest.cc
>> rlz\lib\machine_id_unittest.cc
>> #$ cp trunk/src/rlz/lib/crc32_**wrapper.cc rlz\lib\crc32_wrapper.cc
>> #$ cp trunk/src/rlz/win/lib/machine_**deal.cc rlz\win\lib\machine_deal.cc
>> #$ cp trunk/src/rlz/win/lib/vista_**winnt.h rlz\win\lib\vista_winnt.h
>> #$ cp trunk/src/rlz/win/lib/lib_**mutex.h rlz\win\lib\lib_mutex.h
>> #$ cp trunk/src/rlz/lib/rlz_lib_**clear.cc rlz\lib\rlz_lib_clear.cc
>> ### END SVN COPY METADATA
>> Index: chrome/browser/ui/views/frame/**browser_view.cc
>> ==============================**==============================**=======
>> --- chrome/browser/ui/views/frame/**browser_view.cc       (revision
>> 144073)
>> +++ chrome/browser/ui/views/frame/**browser_view.cc       (working copy)
>> @@ -2487,8 +2487,6 @@
>>     const gfx::Rect& rect,
>>     autofill::PasswordGenerator* password_generator,
>>     const webkit::forms::PasswordForm& form) {
>> -  ui::ThemeProvider* theme_provider = GetWidget()->GetThemeProvider(**);
>> -
>>   // Create a rect in the content bounds that the bubble will point to.
>>   gfx::Point origin(rect.origin());
>>   views::View::**ConvertPointToScreen(**GetTabContentsContainerView(),
>> &origin);
>> @@ -2507,8 +2505,7 @@
>>           tab_contents->web_contents()->**GetRenderViewHost(),
>>           password_generator,
>>           browser_.get(),
>> -          tab_contents->password_**manager(),
>> -          theme_provider);
>> +          tab_contents->password_**manager());
>>
>>   views::BubbleDelegateView::**CreateBubble(bubble);
>>   bubble->SetAlignment(views::**BubbleBorder::ALIGN_ARROW_TO_**
>> MID_ANCHOR);
>> Index: chrome/browser/ui/views/**password_generation_bubble_**view.cc
>> ==============================**==============================**=======
>> --- chrome/browser/ui/views/**password_generation_bubble_**view.cc
>>  (revision 144073)
>> +++ chrome/browser/ui/views/**password_generation_bubble_**view.cc
>>  (working copy)
>> @@ -15,10 +15,7 @@
>>  #include "content/public/browser/**render_view_host.h"
>>  #include "googleurl/src/gurl.h"
>>  #include "grit/generated_resources.h"
>> -#include "grit/theme_resources_**standard.h"
>> -#include "ui/base/theme_provider.h"
>>  #include "ui/base/l10n/l10n_util.h"
>> -#include "ui/views/controls/button/**image_button.h"
>>  #include "ui/views/controls/button/**text_button.h"
>>  #include "ui/views/controls/label.h"
>>  #include "ui/views/controls/link.h"
>> @@ -36,19 +33,16 @@
>>     content::RenderViewHost* render_view_host,
>>     autofill::PasswordGenerator* password_generator,
>>     content::PageNavigator* navigator,
>> -    PasswordManager* password_manager,
>> -    ui::ThemeProvider* theme_provider)
>> +    PasswordManager* password_manager)
>>     : BubbleDelegateView(anchor_**view, views::BubbleBorder::TOP_LEFT)**,
>>       accept_button_(NULL),
>> -      regenerate_button_(NULL),
>>       text_field_(NULL),
>>       anchor_rect_(anchor_rect),
>>       form_(form),
>>       render_view_host_(render_view_**host),
>>       password_generator_(password_**generator),
>>       navigator_(navigator),
>> -      password_manager_(password_**manager),
>> -      theme_provider_(theme_**provider) {}
>> +      password_manager_(password_**manager) {}
>>
>>  PasswordGenerationBubbleView::**~PasswordGenerationBubbleView(**) {}
>>
>> @@ -58,15 +52,6 @@
>>   accept_button_ = new views::NativeTextButton(this,
>>                                                ASCIIToUTF16("Try It"));
>>
>> -  regenerate_button_ = new views::ImageButton(this);
>> -  regenerate_button_->SetImage(**views::CustomButton::BS_**NORMAL,
>> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD))**;
>> -  regenerate_button_->SetImage(**views::CustomButton::BS_HOT,
>> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD_**H));
>> -  regenerate_button_->SetImage(**views::CustomButton::BS_**PUSHED,
>> -      theme_provider_->**GetImageSkiaNamed(IDR_RELOAD_**P));
>> -  regenerate_button_->**SetTooltipText(ASCIIToUTF16("**Regenerate"));
>> -
>>   text_field_ = new views::Textfield();
>>   text_field_->SetText(
>>       ASCIIToUTF16(password_**generator_->Generate()));
>> @@ -94,8 +79,6 @@
>>   cs = layout->AddColumnSet(1);
>>   cs->AddColumn(GridLayout::**FILL, GridLayout::CENTER, 0,
>>                 GridLayout::USE_PREF, 0, 100);
>> -  cs->AddColumn(GridLayout::**FILL, GridLayout::CENTER, 0,
>> GridLayout::FIXED,
>> -                regenerate_button_->**GetPreferredSize().width(), 100);
>>   cs->AddPaddingColumn(1, views::**kRelatedControlHorizontalSpaci**ng);
>>   cs->AddColumn(GridLayout::**TRAILING, GridLayout::CENTER, 0,
>>                 GridLayout::USE_PREF, 0, 0);
>> @@ -106,7 +89,6 @@
>>
>>   layout->StartRow(0, 1);
>>   layout->AddView(text_field_);
>> -  layout->AddView(regenerate_**button_);
>>   layout->AddView(accept_button_**);
>>  }
>>
>> @@ -121,9 +103,6 @@
>>         render_view_host_->**GetRoutingID(), text_field_->text()));
>>     password_manager_->**SetFormHasGeneratedPassword(**form_);
>>     StartFade(false);
>> -  } else if (sender == regenerate_button_) {
>> -    text_field_->SetText(
>> -        ASCIIToUTF16(password_**generator_->Generate()));
>>   }
>>  }
>>
>> Index: chrome/browser/ui/views/**password_generation_bubble_**view.h
>> ==============================**==============================**=======
>> --- chrome/browser/ui/views/**password_generation_bubble_**view.h
>> (revision 144073)
>> +++ chrome/browser/ui/views/**password_generation_bubble_**view.h
>> (working copy)
>> @@ -24,7 +24,6 @@
>>  }
>>
>>  namespace views {
>> -class ImageButton;
>>  class TextButton;
>>  class Textfield;
>>  }
>> @@ -45,8 +44,7 @@
>>                                content::RenderViewHost* render_view_host,
>>                                autofill::PasswordGenerator*
>> password_generator,
>>                                content::PageNavigator* navigator,
>> -                               PasswordManager* password_manager,
>> -                               ui::ThemeProvider* theme_provider);
>> +                               PasswordManager* password_manager);
>>   virtual ~PasswordGenerationBubbleView(**);
>>
>>  private:
>> @@ -66,7 +64,6 @@
>>
>>   // Subviews
>>   views::TextButton* accept_button_;
>> -  views::ImageButton* regenerate_button_;
>>   views::Textfield* text_field_;
>>
>>   // Location that the bubble points to
>> @@ -88,9 +85,6 @@
>>   // PasswordManager associated with this tab.
>>   PasswordManager* password_manager_;
>>
>> -  // Theme provider used to draw the regenerate button.
>> -  ui::ThemeProvider* theme_provider_;
>> -
>>   DISALLOW_COPY_AND_ASSIGN(**PasswordGenerationBubbleView);
>>  };
>>
>>
>> Property changes on: rlz\DEPS
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\OWNERS
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\assert.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\assert.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc32.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc32_unittest.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc32_wrapper.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc8.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc8.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\crc8_unittest.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\financial_ping.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\financial_ping.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\financial_ping_test.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\lib_values.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\lib_values.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\lib_values_unittest.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\machine_id.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\machine_id.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\machine_id_unittest.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_enums.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_lib.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_lib.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_lib_clear.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_lib_test.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\rlz_value_store.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\string_utils.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\string_utils.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\lib\string_utils_unittest.**cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\mac\lib\machine_id_mac.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\mac\lib\rlz_value_store_**mac.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on:
rlz\mac\lib\rlz_value_store_**mac.mm<http://rlz_value_store_mac.mm>
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\rlz.gyp
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\test\rlz_test_helpers.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\test\rlz_test_helpers.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\test\rlz_unittest_main.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\dll\dll_main.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\dll\exports.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\lib_mutex.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\lib_mutex.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\machine_deal.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\machine_deal.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\machine_deal_test.**cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\machine_id_win.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\process_info.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\process_info.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\registry_util.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\registry_util.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\rlz_lib.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\rlz_lib_win.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\rlz_value_store_**registry.cc
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\rlz_value_store_**registry.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>> Property changes on: rlz\win\lib\vista_winnt.h
>> ______________________________**______________________________**_______
>> Added: svn:mergeinfo
>>
>>
>>
>>
>