Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10642009: Add a regenerate button to regenerate the password in Windows. (Closed)

Created:
8 years, 6 months ago by zysxqn
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a regenerate button to regenerate the password in Windows. BUG=120480 TEST=Not tested. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144071

Patch Set 1 #

Patch Set 2 : Remove unused code. #

Total comments: 2

Patch Set 3 : A nit. #

Patch Set 4 : Sync and Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -7104 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.h View 4 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.cc View 1 2 1 chunk +141 lines, -120 lines 0 comments Download
D rlz/DEPS View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D rlz/OWNERS View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D rlz/lib/assert.h View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D rlz/lib/assert.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D rlz/lib/crc32.h View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D rlz/lib/crc32_unittest.cc View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D rlz/lib/crc32_wrapper.cc View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D rlz/lib/crc8.h View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D rlz/lib/crc8.cc View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D rlz/lib/crc8_unittest.cc View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D rlz/lib/financial_ping.h View 1 2 3 1 chunk +0 lines, -64 lines 0 comments Download
D rlz/lib/financial_ping.cc View 1 2 3 1 chunk +0 lines, -354 lines 0 comments Download
D rlz/lib/financial_ping_test.cc View 1 2 3 1 chunk +0 lines, -293 lines 0 comments Download
D rlz/lib/lib_values.h View 1 2 3 1 chunk +0 lines, -99 lines 0 comments Download
D rlz/lib/lib_values.cc View 1 2 3 1 chunk +0 lines, -208 lines 0 comments Download
D rlz/lib/lib_values_unittest.cc View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D rlz/lib/machine_id.h View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D rlz/lib/machine_id.cc View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D rlz/lib/machine_id_unittest.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D rlz/lib/rlz_enums.h View 1 2 3 1 chunk +0 lines, -132 lines 0 comments Download
D rlz/lib/rlz_lib.h View 1 2 3 1 chunk +0 lines, -335 lines 0 comments Download
D rlz/lib/rlz_lib.cc View 1 2 3 1 chunk +0 lines, -651 lines 0 comments Download
D rlz/lib/rlz_lib_clear.cc View 1 2 3 1 chunk +0 lines, -82 lines 0 comments Download
D rlz/lib/rlz_lib_test.cc View 1 2 3 1 chunk +0 lines, -824 lines 0 comments Download
D rlz/lib/rlz_value_store.h View 1 2 3 1 chunk +0 lines, -116 lines 0 comments Download
D rlz/lib/string_utils.h View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
D rlz/lib/string_utils.cc View 1 2 3 1 chunk +0 lines, -92 lines 0 comments Download
D rlz/lib/string_utils_unittest.cc View 1 2 3 1 chunk +0 lines, -69 lines 0 comments Download
D rlz/mac/lib/machine_id_mac.cc View 1 2 3 1 chunk +0 lines, -147 lines 0 comments Download
D rlz/mac/lib/rlz_value_store_mac.h View 1 2 3 1 chunk +0 lines, -80 lines 0 comments Download
D rlz/mac/lib/rlz_value_store_mac.mm View 1 2 3 1 chunk +0 lines, -447 lines 0 comments Download
D rlz/rlz.gyp View 1 2 3 1 chunk +0 lines, -151 lines 0 comments Download
D rlz/test/rlz_test_helpers.h View 1 2 3 1 chunk +0 lines, -33 lines 0 comments Download
D rlz/test/rlz_test_helpers.cc View 1 2 3 1 chunk +0 lines, -86 lines 0 comments Download
D rlz/test/rlz_unittest_main.cc View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
D rlz/win/dll/dll_main.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D rlz/win/dll/exports.cc View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
D rlz/win/lib/lib_mutex.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D rlz/win/lib/lib_mutex.cc View 1 2 3 1 chunk +0 lines, -67 lines 0 comments Download
D rlz/win/lib/machine_deal.h View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D rlz/win/lib/machine_deal.cc View 1 2 3 1 chunk +0 lines, -300 lines 0 comments Download
D rlz/win/lib/machine_deal_test.cc View 1 2 3 1 chunk +0 lines, -156 lines 0 comments Download
D rlz/win/lib/machine_id_win.cc View 1 2 3 1 chunk +0 lines, -130 lines 0 comments Download
D rlz/win/lib/process_info.h View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D rlz/win/lib/process_info.cc View 1 2 3 1 chunk +0 lines, -196 lines 0 comments Download
D rlz/win/lib/registry_util.h View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
D rlz/win/lib/registry_util.cc View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
D rlz/win/lib/rlz_lib.h View 1 2 3 1 chunk +0 lines, -56 lines 0 comments Download
D rlz/win/lib/rlz_lib_win.cc View 1 2 3 1 chunk +0 lines, -260 lines 0 comments Download
D rlz/win/lib/rlz_value_store_registry.h View 1 2 3 1 chunk +0 lines, -55 lines 0 comments Download
D rlz/win/lib/rlz_value_store_registry.cc View 1 2 3 1 chunk +0 lines, -384 lines 0 comments Download
D rlz/win/lib/vista_winnt.h View 1 2 3 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
zysxqn
8 years, 6 months ago (2012-06-22 00:28:03 UTC) #1
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10642009/diff/2001/chrome/browser/ui/views/password_generation_bubble_view.cc File chrome/browser/ui/views/password_generation_bubble_view.cc (right): http://codereview.chromium.org/10642009/diff/2001/chrome/browser/ui/views/password_generation_bubble_view.cc#newcode51 chrome/browser/ui/views/password_generation_bubble_view.cc:51: theme_provider_(theme_provider){} you deleted a space here, put it ...
8 years, 6 months ago (2012-06-22 16:19:31 UTC) #2
zysxqn
Garrett, do you want to have a look before I submit? http://codereview.chromium.org/10642009/diff/2001/chrome/browser/ui/views/password_generation_bubble_view.cc File chrome/browser/ui/views/password_generation_bubble_view.cc (right): ...
8 years, 6 months ago (2012-06-22 23:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@google.com/10642009/5001
8 years, 5 months ago (2012-06-25 17:58:16 UTC) #4
commit-bot: I haz the power
Try job failure for 10642009-5001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-06-25 18:22:46 UTC) #5
Garrett Casto
lgtm
8 years, 5 months ago (2012-06-25 21:03:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@google.com/10642009/11002
8 years, 5 months ago (2012-06-25 22:41:48 UTC) #7
commit-bot: I haz the power
Change committed as 144071
8 years, 5 months ago (2012-06-26 00:28:50 UTC) #8
jam
why did you delete the rlz directory?
8 years, 5 months ago (2012-06-26 00:33:29 UTC) #9
jam
8 years, 5 months ago (2012-06-26 00:33:29 UTC) #10 
why did you delete the rlz directory?

Powered by Google App Engine
This is Rietveld 408576698