Don't show the restart dialog in the GPU process.

Don't show the restart dialog in the GPU process.

BUG=132119
TEST=Go to chrome://inducebrowsercrashforrealz, observe that only a single "Whoa!" dialog appears.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144224

[robertshield, 2012-06-25 15:26:04]

This is a temporary workaround for a ReleaseBlock-Stable bug that somehow landed
in my lap. 

The GPU process can apparently start up quite early, before
env_vars::kShowRestart is cleared. This means that if Chrome is being restarted
as the result of a crash, the "Whoa! Chrome crashed" dialog is shown twice, once
by the restarted browser process and once by the GPU process.

The right fix for this is probably to clear the "I crashed" env. var. earlier. I
could clear it as soon as it has been checked, but that seems to have not been
done on purpose. Any ideas for a better fix are welcome.

[cpu_(ooo_6.6-7.5), 2012-06-25 20:12:36]

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
File chrome/app/chrome_exe_main_win.cc (right):

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
chrome/app/chrome_exe_main_win.cc:24:
command_line.GetSwitchValueASCII(switches::kProcessType);
not opposed to the approach, but I wonder if it would not be better to place
that if inside ShowRestartDialogIfCrashed.

[apatrick_chromium, 2012-06-25 21:34:30]

Maybe related, I am trying to land this, which will disable what might well be
the root cause.

https://chromiumcodereview.appspot.com/10635007/

I plan to re-enable the prelaunching in the future once I see if disabling it
reduces GPU process crashes.

LGTM for my part.

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
File chrome/app/chrome_exe_main_win.cc (right):

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
chrome/app/chrome_exe_main_win.cc:21: // WE explicitly don't do this if we're a
GPU process. See crbug.com/132119.
nit: WE->We

[cpu_(ooo_6.6-7.5), 2012-06-25 21:42:59]

And I forgot a bit of background on the env var. Might not help the CL, but just
fyi:

The env var idea is two fold:
1- set it up somewhat late so if the crash is very early we don't keep
crashing->restarting.
2- set it up when we have the i18n infrastructure up because we show the dialog
very early, for the same reason as #1.

[robertshield, 2012-06-26 00:18:53]

Thanks, moved implementation to ShowRestartDialogIfCrashed. Also excluded all
non-browser processes rather than just the GPU process. PTAL.

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
File chrome/app/chrome_exe_main_win.cc (right):

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
chrome/app/chrome_exe_main_win.cc:21: // WE explicitly don't do this if we're a
GPU process. See crbug.com/132119.
On 2012/06/25 21:34:30, apatrick_chromium wrote:
> nit: WE->We

Done.

https://chromiumcodereview.appspot.com/10657024/diff/1/chrome/app/chrome_exe_...
chrome/app/chrome_exe_main_win.cc:24:
command_line.GetSwitchValueASCII(switches::kProcessType);
On 2012/06/25 20:12:36, cpu wrote:
> not opposed to the approach, but I wonder if it would not be better to place
> that if inside ShowRestartDialogIfCrashed.

Done.

[commit-bot: I haz the power, 2012-06-26 16:57:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10657024/9001

[cpu_(ooo_6.6-7.5), 2012-06-26 18:21:17]

lgtm

[commit-bot: I haz the power, 2012-06-26 18:59:31]

Change committed as 144224