Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10649003: Move each permission classes to its own files in extensions/permissions (Closed)

Created:
8 years, 6 months ago by penghuang%chromium.org
Modified:
8 years, 5 months ago
Reviewers:
miket_OOO, Peng, Evan Stade, aa
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, mihaip-chromium-reviews_chromium.org, jeremya+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, estade+watch_chromium.org, bryeung
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move each permission classes to its own files in extensions/permissions and rename classes from ExtensionPermission* to extensions::Permission* BUG=133049 TEST=unit_tests & browser_tests

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Rebase on HEAD #

Total comments: 2

Patch Set 4 : Rebase on HEAD and fix review issues #

Patch Set 5 : Rebase on HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2161 lines, -3161 lines) Patch
M chrome/browser/background/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_permission_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 7 chunks +20 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 1 4 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_info_map.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 9 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_preference_helpers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_preference_helpers.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 12 chunks +29 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 14 chunks +34 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 5 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 12 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater.h View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/settings/settings_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 1 2 14 chunks +26 lines, -26 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 27 chunks +39 lines, -38 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 2 3 4 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 3 chunks +6 lines, -5 lines 0 comments Download
D chrome/common/extensions/extension_permission_set.h View 1 2 3 4 1 chunk +0 lines, -471 lines 0 comments Download
D chrome/common/extensions/extension_permission_set.cc View 1 2 3 4 1 chunk +0 lines, -951 lines 0 comments Download
D chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1156 lines 0 comments Download
M chrome/common/extensions/features/permission_feature.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 1 chunk +160 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/api_permission.cc View 1 2 3 4 1 chunk +182 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_message.h View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_message.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_set.h View 1 1 chunk +205 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_set.cc View 1 2 3 4 1 chunk +651 lines, -0 lines 0 comments Download
A + chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 51 chunks +229 lines, -226 lines 0 comments Download
A chrome/common/extensions/permissions/permissions_info.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permissions_info.cc View 1 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.h View 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 3 4 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Peng
Hi Aaron, Please take a look. Thanks.
8 years, 6 months ago (2012-06-21 21:53:29 UTC) #1
Peng
On 2012/06/21 21:53:29, Peng wrote: > Hi Aaron, Please take a look. Thanks. kindly ping.
8 years, 6 months ago (2012-06-25 16:46:56 UTC) #2
miket_OOO
LGTM but please see my one comment and consider optimizing the code a bit. https://chromiumcodereview.appspot.com/10649003/diff/19001/chrome/browser/extensions/extension_info_map.h ...
8 years, 6 months ago (2012-06-25 22:01:11 UTC) #3
Peng
https://chromiumcodereview.appspot.com/10649003/diff/19001/chrome/browser/extensions/extension_info_map.h File chrome/browser/extensions/extension_info_map.h (right): https://chromiumcodereview.appspot.com/10649003/diff/19001/chrome/browser/extensions/extension_info_map.h#newcode20 chrome/browser/extensions/extension_info_map.h:20: using extensions::APIPermission; On 2012/06/25 22:01:11, miket wrote: > In ...
8 years, 6 months ago (2012-06-25 22:49:01 UTC) #4
Peng
+estade, owner review for file in chrome/browser/ui/webui. thanks.
8 years, 6 months ago (2012-06-25 22:51:55 UTC) #5
Evan Stade
webui lgtm
8 years, 6 months ago (2012-06-26 01:30:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang%chromium.org@gtempaccount.com/10649003/22001
8 years, 6 months ago (2012-06-26 02:33:55 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/permissions/permission_set_unittest.cc: While running patch -p1 --forward --force; A chrome/common/extensions/permissions patching ...
8 years, 6 months ago (2012-06-26 02:34:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang%chromium.org@gtempaccount.com/10649003/20002
8 years, 6 months ago (2012-06-26 02:47:09 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-26 02:47:29 UTC) #10
Presubmit check for 10649003-20002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
penghuang%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 4.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698