Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 10649003: Move each permission classes to its own files in extensions/permissions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase on HEAD Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
11 #include "chrome/common/extensions/extension.h" 11 #include "chrome/common/extensions/extension.h"
12 #include "chrome/common/extensions/extension_error_utils.h" 12 #include "chrome/common/extensions/extension_error_utils.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h" 13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/common/extensions/features/simple_feature_provider.h" 14 #include "chrome/common/extensions/features/simple_feature_provider.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 16
17 namespace errors = extension_manifest_errors; 17 namespace errors = extension_manifest_errors;
18 18
19 namespace extensions { 19 namespace extensions {
20 20
21 TEST_F(ExtensionManifestTest, BackgroundPermission) { 21 TEST_F(ExtensionManifestTest, BackgroundPermission) {
22 LoadAndExpectError("background_permission.json", 22 LoadAndExpectError("background_permission.json",
23 errors::kBackgroundPermissionNeeded); 23 errors::kBackgroundPermissionNeeded);
24 24
25 scoped_refptr<Extension> extension; 25 scoped_refptr<Extension> extension;
26 extension = LoadAndExpectSuccess("background_permission_alias.json"); 26 extension = LoadAndExpectSuccess("background_permission_alias.json");
27 EXPECT_TRUE(extension->HasAPIPermission(ExtensionAPIPermission::kBackground)); 27 EXPECT_TRUE(extension->HasAPIPermission(
28 extensions::APIPermission::kBackground));
28 } 29 }
29 30
30 TEST_F(ExtensionManifestTest, BackgroundScripts) { 31 TEST_F(ExtensionManifestTest, BackgroundScripts) {
31 std::string error; 32 std::string error;
32 scoped_ptr<DictionaryValue> manifest( 33 scoped_ptr<DictionaryValue> manifest(
33 LoadManifestFile("background_scripts.json", &error)); 34 LoadManifestFile("background_scripts.json", &error));
34 ASSERT_TRUE(manifest.get()); 35 ASSERT_TRUE(manifest.get());
35 36
36 scoped_refptr<Extension> extension( 37 scoped_refptr<Extension> extension(
37 LoadAndExpectSuccess(Manifest(manifest.get(), ""))); 38 LoadAndExpectSuccess(Manifest(manifest.get(), "")));
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 EXPECT_TRUE(extension->has_lazy_background_page()); 101 EXPECT_TRUE(extension->has_lazy_background_page());
101 102
102 ListValue* permissions = new ListValue(); 103 ListValue* permissions = new ListValue();
103 permissions->Append(Value::CreateStringValue("webRequest")); 104 permissions->Append(Value::CreateStringValue("webRequest"));
104 manifest->Set(keys::kPermissions, permissions); 105 manifest->Set(keys::kPermissions, permissions);
105 LoadAndExpectError(Manifest(manifest.get(), ""), 106 LoadAndExpectError(Manifest(manifest.get(), ""),
106 errors::kWebRequestConflictsWithLazyBackground); 107 errors::kWebRequestConflictsWithLazyBackground);
107 } 108 }
108 109
109 } // namespace extensions 110 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698