Issue 10643004: Merge 143290 - Replace all spaces by '_' in the AppUserModelId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10643004: Merge 143290 - Replace all spaces by '_' in the AppUserModelId (Closed)

Created:
8 years, 6 months ago by karen

Modified:
8 years, 6 months ago

Reviewers:
gab

CC:
chromium-reviews, erikwright (departed), grt+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

More Reviews

Description

Merge 143290 - Replace all spaces by '_' in the AppUserModelId Adjust DCHECKs in base::win::SetAppIdForPropertyStore() to reflect the new appid standard which requires less than 64 characters, not 128 (as of Windows 8, see Metro guidelines for details). BUG=133176 TEST=Chrome installs, launches, and multi-profile OS integration works for user-level installs (on a user with a space in username). Review URL: https://chromiumcodereview.appspot.com/10559097 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143430

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	base/win/win_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/installer/util/shell_util.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages