Replace all spaces by '_' in the AppUserModelId

Replace all spaces by '_' in the AppUserModelId

Adjust DCHECKs in base::win::SetAppIdForPropertyStore() to reflect the new appid standard which requires less than 64 characters, not 128 (as of Windows 8, see Metro guidelines for details).

BUG=133716
TEST=Chrome installs, launches, and multi-profile OS integration works for user-level installs (on a user with a space in username).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143290

[robertshield, 2012-06-20 21:50:16]

pre-emptive LGTM, but please address the comments

https://chromiumcodereview.appspot.com/10559097/diff/1/base/win/win_util.cc
File base/win/win_util.cc (right):

https://chromiumcodereview.appspot.com/10559097/diff/1/base/win/win_util.cc#n...
base/win/win_util.cc:183: // App id should be less than 64 chars and contain no
space. And recommended
this does not look to be part of the CL description

https://chromiumcodereview.appspot.com/10559097/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/10559097/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:1122: ReplaceChars(component, L" ", L"_",
&component);
could you do this replacement at the end of the loop on the app_id string?

[gab, 2012-06-20 21:58:36]

Done.

https://chromiumcodereview.appspot.com/10559097/diff/1/base/win/win_util.cc
File base/win/win_util.cc (right):

https://chromiumcodereview.appspot.com/10559097/diff/1/base/win/win_util.cc#n...
base/win/win_util.cc:183: // App id should be less than 64 chars and contain no
space. And recommended
On 2012/06/20 21:50:16, robertshield wrote:
> this does not look to be part of the CL description

Done.

https://chromiumcodereview.appspot.com/10559097/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/10559097/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:1122: ReplaceChars(component, L" ", L"_",
&component);
On 2012/06/20 21:50:16, robertshield wrote:
> could you do this replacement at the end of the loop on the app_id string?

Done.

[brettw, 2012-06-20 22:00:22]

lgtm

[commit-bot: I haz the power, 2012-06-20 22:01:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10559097/4001

[commit-bot: I haz the power, 2012-06-20 23:13:36]

Change committed as 143290