Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/renderer/security_filter_peer.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: hack, hack, hack Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/security_filter_peer.cc
diff --git a/chrome/renderer/security_filter_peer.cc b/chrome/renderer/security_filter_peer.cc
index ee05496fea5b5fdc99665cd335aa73971fd6e693..f075458743eec079f585143ef4fc6182cf70a46a 100644
--- a/chrome/renderer/security_filter_peer.cc
+++ b/chrome/renderer/security_filter_peer.cc
@@ -91,6 +91,7 @@ void SecurityFilterPeer::OnReceivedData(const char* data,
void SecurityFilterPeer::OnCompletedRequest(
const net::URLRequestStatus& status,
+ bool handled_externally,
const std::string& security_info,
const base::TimeTicks& completion_time) {
NOTREACHED();
@@ -151,6 +152,7 @@ void BufferedPeer::OnReceivedData(const char* data,
}
void BufferedPeer::OnCompletedRequest(const net::URLRequestStatus& status,
+ bool handled_externally,
const std::string& security_info,
const base::TimeTicks& completion_time) {
// Make sure we delete ourselves at the end of this call.
@@ -162,7 +164,8 @@ void BufferedPeer::OnCompletedRequest(const net::URLRequestStatus& status,
original_peer_->OnReceivedResponse(response_info_);
net::URLRequestStatus status(net::URLRequestStatus::CANCELED,
net::ERR_ABORTED);
- original_peer_->OnCompletedRequest(status, security_info, completion_time);
+ original_peer_->OnCompletedRequest(status, handled_externally,
+ security_info, completion_time);
return;
}
@@ -171,7 +174,8 @@ void BufferedPeer::OnCompletedRequest(const net::URLRequestStatus& status,
original_peer_->OnReceivedData(data_.data(),
static_cast<int>(data_.size()),
-1);
- original_peer_->OnCompletedRequest(status, security_info, completion_time);
+ original_peer_->OnCompletedRequest(status, handled_externally,
+ security_info, completion_time);
}
////////////////////////////////////////////////////////////////////////////////
@@ -203,6 +207,7 @@ void ReplaceContentPeer::OnReceivedData(const char* data,
void ReplaceContentPeer::OnCompletedRequest(
const net::URLRequestStatus& status,
+ bool handled_externally,
const std::string& security_info,
const base::TimeTicks& completion_time) {
webkit_glue::ResourceResponseInfo info;
@@ -215,6 +220,7 @@ void ReplaceContentPeer::OnCompletedRequest(
static_cast<int>(data_.size()),
-1);
original_peer_->OnCompletedRequest(net::URLRequestStatus(),
+ handled_externally,
security_info,
completion_time);

Powered by Google App Engine
This is Rietveld 408576698