Remove the HANDLED_EXTERNALLY status code.

content/browser/renderer_host/resource_loader.cc

Index: content/browser/renderer_host/resource_loader.cc
diff --git a/content/browser/renderer_host/resource_loader.cc b/content/browser/renderer_host/resource_loader.cc
index be923ca81f9f7dae88c38ee5ac58a5a459ee38e7..af9685fc45c31094ee465816f349b7cc8a668656 100644
--- a/content/browser/renderer_host/resource_loader.cc
+++ b/content/browser/renderer_host/resource_loader.cc
@@ -82,7 +82,8 @@ ResourceLoader::~ResourceLoader() {
 
 void ResourceLoader::StartRequest() {
   if (delegate_->HandleExternalProtocol(this, request_->url())) {
-    CancelRequestInternal(net::ERR_UNKNOWN_URL_SCHEME, false);
+    GetRequestInfo()->set_handled_externally(true);
+    CancelRequestInternal(net::ERR_ABORTED, false);
     return;
   }
 
@@ -105,6 +106,11 @@ void ResourceLoader::CancelRequest(bool from_renderer) {
   CancelRequestInternal(net::ERR_ABORTED, from_renderer);
 }
 
+void ResourceLoader::CancelWithHandledExternally() {
+  GetRequestInfo()->set_handled_externally(true);
+  CancelRequestInternal(net::ERR_ABORTED, false);

[darin (slow to review), 2012/06/25 16:15:32]

another idea, which may be too crazy, is to just get rid of URLRequestStatus
entirely.  since net::ERR_ABORTED implies cancellation at the WebURLLoaderImpl
level, we don't really even need to pass the URLRequestStatus::status() member.

Furthermore (and this is maybe where my proposal gets crazy), since net:: error
codes are all negative, we could use a positive value to indicate "handled
externally".  This is not entirely odd as that is not really an error condition.
 We know that network error codes will never be positive since various network
level interfaces use an integer to pass either byte counts or error codes.

It seems like it might simplify the code if we just had a single int error code
field to pass around and inspect.  Thoughts?

+}
+
 void ResourceLoader::ReportUploadProgress() {
   ResourceRequestInfoImpl* info = GetRequestInfo();
 
@@ -203,7 +209,8 @@ void ResourceLoader::OnReceivedRedirect(net::URLRequest* unused,
 
   if (delegate_->HandleExternalProtocol(this, new_url)) {
     // The request is complete so we can remove it.
-    CancelRequestInternal(net::ERR_UNKNOWN_URL_SCHEME, false);
+    GetRequestInfo()->set_handled_externally(true);
+    CancelRequestInternal(net::ERR_ABORTED, false);
     return;
   }