gdata: Stop getting GDataUploader via GDataSystemService

gdata: Stop getting GDataUploader via GDataSystemService

For writing upload related unit tests in gdata_file_system_unittest.cc,
we need to be able to inject a mock GDataUploader.
Otherwise, GDataFileSystem ends up using a production GDataUploader
that makes real HTTP requests to the gdata server.

Note that this is a stop-gap solution. The inter-dependencies between
GDataUploader and GDataSystemService should be eliminated.

BUG=127080, 133860
TEST=uploading works as before


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143559

[hshi1, 2012-06-21 19:50:20]

https://chromiumcodereview.appspot.com/10640006/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

https://chromiumcodereview.appspot.com/10640006/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:1290:
scoped_ptr<StrictMock<MockGDataUploader> > mock_uploader_;
By using StrictMock here is the intention to catch all unexpected calls to the
mock_uploader_?

https://chromiumcodereview.appspot.com/10640006/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_system_service.cc (right):

https://chromiumcodereview.appspot.com/10640006/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_system_service.cc:83: file_system_.reset();
Now uploader_ is created before file_system_, I think it should be shut it after
file_system_?

[satorux1, 2012-06-21 19:57:46]

http://codereview.chromium.org/10640006/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

http://codereview.chromium.org/10640006/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:1290:
scoped_ptr<StrictMock<MockGDataUploader> > mock_uploader_;
On 2012/06/21 19:50:20, hshi1 wrote:
> By using StrictMock here is the intention to catch all unexpected calls to the
> mock_uploader_?

Yes. We should use it more widely.

http://codereview.chromium.org/10640006/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_system_service.cc (right):

http://codereview.chromium.org/10640006/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_system_service.cc:83: file_system_.reset();
On 2012/06/21 19:50:20, hshi1 wrote:
> Now uploader_ is created before file_system_, I think it should be shut it
after
> file_system_?

Good catch! Done.

[hshi1, 2012-06-21 20:06:58]

Thanks and lgtm.

[commit-bot: I haz the power, 2012-06-22 06:41:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/10640006/5003

[commit-bot: I haz the power, 2012-06-22 07:54:09]

Change committed as 143559